Repository navigation
Fix set_update_step for scoped parameters - #49
Merged
LaurenzBeck merged 1 commit intoOct 29, 2026
Merged
Conversation
Signed-off-by: Umut Alisoglu <umutalisoglu@gmail.com>
Contributor
|
good catch @UmutAlisoglu ! 💪🏻 Your added test files are a good addition and seem correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ParameterStore({"scope": {"rate": {"schedule": [10, 20, 30]}}}).set_update_step(2)indexes the scope dictionary with2and raisesKeyError, rather than updating its parameter. Iterate the registered parameter names and use the existing scoped lookup, asupdate()already does. Unscoped and constant parameters retain their behavior.The regression covers scoped-only and mixed stores, multiple scopes sharing a parameter name, a constant value, jumping forward, resetting, and advancing after reset. Both new cases fail on unchanged main.
How this was tested
Windows / Python 3.13.7, current declared runtime dependencies (beartype 0.23.1, pandas 3.1.0, NumPy 2.5.4):
coverage run --source=streamgen -m pytest -q: 39 pass, 22 existing Python/dependency warnings; ParameterStore coverage 97%.No dependency or lockfile changes. The method docstring now explicitly includes scoped parameters.
AI assistance was used for implementation and regression tests. Signed off.