Skip to content

Trace CANNBot round knowledge in managed optimization - #523

Merged
jiangkuaixue123 merged 2 commits into
mainfrom
codex/cannbot-round-retrieval
Nov 20, 2026
Merged

jiangkuaixue123 merged 2 commits into
mainfrom
codex/cannbot-round-retrieval

Conversation

@jiangkuaixue123

@jiangkuaixue123 jiangkuaixue123 commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Governing Issue and delivery slice

Refs #522

Add opt-in CANNBot retrieval and explicit knowledge citations to managed benchmark sessions and AB/BA campaigns. The implementation uses the existing per-project CANNBot grant and the current apps.integrations.cannbot adapter.

Requirement Implementation and evidence
Round retrieval and degradation start --cannbot-platform <platform> freezes the Ascend platform. The flag defaults to off. knowledge returns separate local and CANNBot results. The timeout regression checks stable local result IDs and rankings, local citation, and reserved final evaluation.
Pinned card identity and retention knowledge-read verifies the selected search hit's revision and digest before returning the requested page. Retained receipts carry identity metadata. Dashboard validates scalar values and search/read linkage before display.
Candidate attribution round --knowledge-ref cites an explicitly delivered local item or pinned read receipt. The settled observation binds citations to the submitted context snapshot. Round decisions shows these citations beside evaluator outcomes. Native Codex trace verification recognizes the exact local envelope in both local-only and joint tool returns.
Current main integration The implementation follows the current Apps migration inventory and measured-diagnosis controls. The checked-in Dashboard profile example is regenerated from its fixture.

Review follow-up

  • Preserved the three-field local reference. Return format review
  • Bound completed-round attribution to the verified observation and its submitted context snapshot. Attribution review
  • Added typed validation for external metadata, with malformed nested fields and invalid receipt linkage covered by regression tests. Metadata review

Current-head review follow-up

  • cc552e47 routes local managed context projection through the same bounded read as external receipts. The Harness uses the protected reader from its first access through citation lookup. Both verify SHA-256 against the retained reference. Regression coverage includes absolute and escaping paths, file and ancestor symlinks, oversized records, and digest mismatch. Amy's review
  • Independent incremental review returned PASS on cc552e47 against f0e92e8d. Exact-head targeted checks passed 214 tests and Ruff, with one compatibility test skipped because it requires a pinned pre-migration wheel. The preceding head 24f5e08a passed both full-check jobs, Chromium, and installed-package CI. Preceding head CI

Verification on the preceding head

  • Independent Codex review returned PASS for base f0e92e8d and head 24f5e08a after rechecking service-reuse compatibility. GitHub maintainer review remains pending.
  • The reviewed head passed the synthetic worker checks for a pinned page read and a real subprocess timeout, including candidate attribution and independent final evaluation. Clean sdist/wheel build and the installed-package smoke also passed.
  • The reviewed head passed 94 focused tests covering CANNBot boundaries, managed optimization, native round citations, Round decisions in Chromium and P1 preparation, plus 27 benchmark comparison tests and Ruff. The local Ready Chromium selection passed 68 tests on the preceding revision with equivalent browser behavior. The migration inventory and byte-for-byte Dashboard fixture passed on the reviewed head.
  • On local macOS, the full service-reuse file produced the same 19 passes and 70 process-cleanup permission failures on both main and the reviewed head. The reviewer also reproduced two Git-version-dependent Anthropic snapshot failures on both revisions. GitHub Actions records Linux results for the new head.

Remaining work and Issue acceptance

Production CANNBot grant and Ascend workload verification remain open. Issue #522 remains open for requester acceptance.

zengchuang-hw
zengchuang-hw previously approved these changes Nov 19, 2026

@zengchuang-hw zengchuang-hw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PASS

首轮检视,c573f40a43ceef23ef08507fca662c95ffb65390 → 226f8d0f5fb114443ed76311879e78f24b4b6180,覆盖全部 14 个变更文件,按 #522 的软件交付范围核对。

实际追踪了 CLI → managed session → Harness → CANNBot 渠道与 worker。未开启时不调用外部渠道;搜索和读取分开,读取要求当前轮 locator 并校验 revision、digest 和 page。正文不写入留存 trace;候选只能引用已送达的本地条目或外部读取回执,搜索命中和未引用的读取均不算采用。Dashboard 读取同一记录,分别展示来源、状态、引用及 evaluator 分数,没有更改候选选择。

批准前必做:无。已静态阅读覆盖查找、读取、引用、不可用及留存最小化的用例;未运行代码、测试、浏览器或生产 grant/Ascend 集成,不据此宣称硬件验收或性能收益。

@david6666666 david6666666 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the managed retrieval and Dashboard attribution paths on this head. Two findings below.

Comment thread src/inferrsi/harness/optimization.py Outdated
reference = {"path": path.relative_to(root).as_posix(), "sha256": fingerprint,
"kind": "delivered_context"}
if number is not None:
reference["round"] = number

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds round to the returned reference even with CANNBot off. capture_delivery.managed_envelopes() still reconstructs the exact three-field {path, sha256, kind} response, so the trace verifier can no longer match these genuine local searches. Both Ready jobs fail four citation regressions. Please keep round on the retained state reference only, or version the envelope and verify both old and new traces.

"status": facts, "evaluation": judged},
usage=record["observations"]["usage"],
measured_score=_number(assessment.get("score")),
knowledge_uses=[citations[ref] for ref in record.get("knowledge_refs") or []

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves mutable state.json citations against the current session-wide context map. _load() verifies the observation file's hash but doesn't compare its recorded citations and context snapshot with state. A completed round can therefore display a later receipt as cited while its verified observation stays unchanged. Please resolve completed-round citations from the verified observation and submitted context snapshot, or check that state matches both, with a regression for later receipts.

@Dong1017 Dong1017 added the kind:task Bounded delivery task with a delegated slice label Nov 19, 2026

Copy link
Copy Markdown
Collaborator Author

@zengchuang-hw @david6666666 麻烦重新评审当前提交 8bbc58cc。这版恢复了纯本地知识查询的返回格式,并把已完成候选的知识引用绑定到评测时留存的上下文快照。原来失败的 4 项引用测试已在本地通过。 返回格式 · 引用归属

当前提交的 Dashboard 浏览器检查已通过,Python 3.10 和 3.11 的 full-check 测试仍有失败。 CI 结果

如果复核后认可当前改动,请在 GitHub 提交 Approve,正文第一行单独写 LGTM。

zengchuang-hw
zengchuang-hw previously approved these changes Nov 19, 2026

@zengchuang-hw zengchuang-hw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PASS

增量检视 226f8d0f5fb114443ed76311879e78f24b4b6180 → 8bbc58ccbb05fee2b0ad2f44209a7badea9732b2,承接上轮检视。本轮只有一个提交,覆盖控制器及回归测试。读取已完成候选时,现在先核对原始 observation 摘要,再核对原始引用和当时的 context 快照;已引用的 receipt 不能被后续轮次悄悄换掉。留存时仍保存 round,本地调用恢复原先的精简响应字段。已核对新检查与真实 settle 写入一致,也确认两边都没有 knowledge_refs 的旧记录不会因此失败。

批准前必做:无。合入协调:独立于本轮检视,#526 若先合,旧 apps.cannbot 兼容层不导出 SCORE_SCALE。后合入的一方应把 round_knowledge.py 及相关导入迁到 apps.integrations.cannbot,核对安装包 worker 和 managed attribution smoke;未做组合验证。 本轮未执行代码、测试或实机验证。

@david6666666 david6666666 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remaining Dashboard metadata validation concern.

# The digest checks file integrity, not whether the record's
# fields are safe to disclose. Expose only known view metadata.
search = {
**{key: record.get(key) for key in (

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metadata field allowlist does not validate the values. public_value() preserves nested objects and lists, so a digest-valid retained record can still carry card content or diagnostics inside an allowed field. The existing regression only covers extra top-level fields. Please validate the expected scalar types and formats for search and read metadata before projection, and cover malformed values.

@Dong1017

Copy link
Copy Markdown
Collaborator

Posted by an agent on behalf of @Dong1017 (incremental review only; points already raised by others are not repeated).

DO NOT PASS — reviewed head 8bbc58ccbb05fee2b0ad2f44209a7badea9732b2. Two blocking points: a new one, and @david6666666's latest comment (r4631124370), which I reproduced and can extend with the exact lines, the visible consequence, and a neighbouring read path he did not mention. @david6666666's two earlier threads are addressed at this head: capture_context again returns the exact three-field {path, sha256, kind} envelope while round stays on the retained state entry, and _load() now rejects a completed round whose citations or submitted context snapshot disagree with its verified observation. Their regressions pass here.

Blocking

  1. Both full-check jobs are red on this head, because the published example page was not regenerated after the view changed.

    test_published_profile_example_matches_fixture (tests/test_profile_story_checks.py:21) fails on 3.10 and 3.11 (run 44545533153, jobs 135634949750 and 135634949698) and is the only failure in each (1 failed, 5512 passed). docs/examples/dashboard-profile-review.html still embeds the pre-change round_decision_view.html; the regenerated page differs by the new managedRetrieval() and knowledgeUses() helpers plus the render() edits. So the feature is documented and tested but the published sample no longer shows the committed view.

    Reproduced and fixed locally at this head:

    $ python tests/fixtures/dashboard_profile_review.py /tmp/regen
    $ diff /tmp/regen/dashboard.html docs/examples/dashboard-profile-review.html  → 57 changed lines, all in round_decision_view
    $ pytest tests/test_profile_story_checks.py -k published_profile_example   → 1 passed (after copying the regenerated page)
    

    Please regenerate the example in this PR so it ships with the view it illustrates.

  2. @david6666666's r4631124370 holds, and the untyped pass-through is broader than public_value() alone.

    managed_knowledge() copies the search record field by field with record.get(key) (src/inferrsi/apps/views/retrieval_projection.py:345-354), and public_value() only recurses and redacts strings — it never checks that count is an integer, state a string, or elapsed_ms a number. Replacing count with {"text": "<card body>"} on a digest-valid retained record puts that object straight into the Dashboard payload; the string is not redacted because it is not a URL, address or credential. The same shape applies to page on a read receipt (:357-358) and to revision, card_sha256 and page in the citation projection (:359-363).

    What the view then does with it, which is why I would treat this as blocking rather than cosmetic: round_decision_view.html:52-54 prints result.count through raw() (a non-scalar renders as [object Object]) and compares result.count > result.items.length, which is silently false against an object. The "some hits lack retainable identifiers" note therefore disappears rather than failing loudly, so a malformed record degrades into a plausible-looking round.

    One related point he did not mention: managed_knowledge() reads each context with json.loads((root / path).read_text("utf-8")) and never calls the module's own _read(), so it skips the inside() containment check, the symlink refusal and the 4 MiB cap that every other record read in this file goes through (:73-87). I confirmed {"path": "../outside.json", ...} resolves and is parsed, while _read() correctly returns unsafe_path. _store_knowledge() only ever writes knowledge/<kind>-<uuid>.json, so the normal path cannot reach this; but this PR explicitly claims the property "even an imported record with a matching digest must not widen the view" (tests/test_optimization_session.py, final block of test_cannbot_query_and_read_trace_to_candidate), and these two gaps are on the same accepted-record path that guarantee is meant to cover. Suggested fix: type-check the allowlisted scalars before projection (as r4631124370 asks) and route the record read through _read(), then extend the existing regression to cover a malformed count/page and a context path outside the root.

Non-blocking

  • I checked the context-snapshot binding for a round I can make fail: a missing or changed capture raises Delivered knowledge context changed in _load() before any projection runs, later receipts appended to an earlier candidate and a receipt replaced at the same path both raise Round knowledge attribution differs… / Cited knowledge context differs…. For older sessions I checked the base rather than relying on the incremental PASS: evaluate_round already wrote both knowledge_refs and contexts into the pending record at a3e33851 (optimization.py:387,389), so the new comparison is comparing a field to itself for pre-change rounds and does not add a new failure surface. Nothing to add beyond that.
  • The local return shape, the --knowledge off rejection, the current-round restriction on knowledge-read, and metadata-only retention all match the task: Trace CANNBot knowledge through optimization rounds and the Dashboard #522 acceptance wording. The combined query being redacted before the local search runs is documented in docs/optimization-benchmarks.md, so I do not read it as a defect.

Scope checked: the 226f8d0f..8bbc58cc delta (optimization.py, tests/test_optimization_session.py) and the full a3e33851..8bbc58cc diff across the 14 source/doc/test files; #523 body and both bot/human comment threads; #522 goal and acceptance; the two earlier @david6666666 threads. Ran tests/test_optimization_session.py, tests/test_project_optimization.py and tests/test_round_decisions_browser.py at this head (all pass), test_profile_story_checks.py::test_published_profile_example_matches_fixture at this head and at base a3e33851 (fails only at this head), and the two projection probes above in an isolated worktree on Python 3.12. Not run: the full suite, real CANNBot grant, Ascend hardware, or the Playwright-dependent browser cases (playwright is not installed here; CI reports these skipped too). PR-head CI state read from run 44545533153.

@david6666666

Copy link
Copy Markdown
Collaborator

#516 has been merged into main. Please rebase this branch onto the latest main and adjust the changes as needed. Please verify that a managed round can still capture local knowledge from the updated catalog and read a pinned CANNBot result.

Copy link
Copy Markdown
Collaborator

PR review verdict — DO NOT PASS

已检视 base c573f40a43ceef23ef08507fca662c95ffb65390 到 head 8bbc58ccbb05fee2b0ad2f44209a7badea9732b2 的完整 diff。当前 head 上仍有未解除的阻塞,因此暂不 Approve。

@david6666666 在旧 head 上的两点已经在 8bbc58cc 修好:capture_context 对纯本地查询仍返回三字段 {path, sha256, kind},round 只写在留存的 state 条目上;_load() 会把已完成轮次的 knowledge_refs / contexts 与通过摘要校验的 observation 以及当时提交的 context 快照对照,后续轮次换掉的 receipt 不能再被算作当时的引用。

下面两项在当前 head 上仍然成立。

  1. 发布的 Dashboard 示例页没有随视图一起再生。 本 PR 改了 src/inferrsi/apps/views/round_decision_view.html(新增 managedRetrieval() / knowledgeUses() 以及 render() 的相应调用),但没有更新 docs/examples/dashboard-profile-review.html。@Dong1017 已在本 head 复现 tests/test_profile_story_checks.py::test_published_profile_example_matches_fixture 在 Python 3.10/3.11 的 full-check 中失败(run 44545533153),并确认再生后的页面与示例相差 57 行,全部来自该视图。请在本 PR 中重新生成并提交该示例,使已发布样例与当前视图一致。

  2. Dashboard 投影仍未校验元数据的类型与读路径。 src/inferrsi/apps/views/retrieval_projection.py 的 managed_knowledge()(约 314–372 行)按字段名拷贝 count / state / elapsed_ms / page / revision / card_sha256 等,随后只经 public_value() 处理;该函数会递归并脱敏字符串,但并不要求 count 为整数、state 为字符串。摘要合法的留存记录如果把 count 写成对象(例如 {"text": "<card body>"}),会进入 Dashboard 载荷。round_decision_view.html 用 raw() 打印 result.count,并用 result.count > result.items.length 决定是否显示“部分命中缺少可留存的标识”——对非标量这两个行为都会静默退化,而不是明确失败。同一函数还用 json.loads((root / path).read_text("utf-8")) 读 context,不走本模块的 _read()(约 73–87 行),因此跳过了路径包含检查、符号链接拒绝和 4 MiB 上限。请在投影前校验允许字段的标量类型与格式,把记录读取改到 _read(),并扩展现有回归,覆盖畸形的 count/page 以及根目录之外的 context 路径。这与 @david6666666 在 r4631124370 的意见一致,范围按上面的邻接读路径补全。

合入前还请处理两项协调(不是本轮代码结论的替代):#516 合入后需要再 rebase 到当前 main,并确认受管轮次仍能从更新后的目录捕获本地知识、读取钉住的 CANNBot 结果;若 #526 先合,后合的一方需要把 round_knowledge.py 及相关导入迁到 apps.integrations.cannbot。我没有重跑完整测试套件,也没有做生产 grant 或昇腾实机验证。

@Dong1017

Copy link
Copy Markdown
Collaborator

Posted by Dong-bot, an automated agent acting on behalf of @Dong1017 (always-on-bot, model claude-sonnet-5-5).

维持 DO NOT PASS。@amy-why-3459 指出的两项我在完整 diff(c573f40a → 8bbc58cc,diffComplete)里逐处核对过,都成立,不是转述评审记录。

1. 示例页未再生 — diff 里确实没有那个文件。
本 PR 的 docs/ 改动只有 external-channels.md、operations.md、optimization-benchmarks.md 三个文件;docs/examples/dashboard-profile-review.html 完全不在 diff 中。而 round_decision_view.html 新增了 managedRetrieval(stage, record) / knowledgeUses(box, candidate, hasQueries) 两个函数,并改写了 render() 里 numbers、contextIds、results 分支的三处逻辑。该示例页内嵌视图,所以 test_published_profile_example_matches_fixture 在这个 head 上必然红;作者本人在 7013342401 也承认 3.10 / 3.11 的 full-check 仍有失败。当前 head 是红的,不能 Approve。

2. managed_knowledge() 只做字段白名单拷贝,不做值校验;读路径也绕过了 _read()。

  • retrieval_projection.py:search = {**{key: record.get(key) for key in ("channel", "backend", "platform", "state", "revision", "score_scale", "count", "elapsed_ms")}, ...},最后只经 public_value(list(queries.values()))。public_value() 递归并脱敏字符串,但不要求 count 是整数、state 是字符串。摘要合法的记录把 count 写成对象就会进 Dashboard 载荷。
  • 同一循环开头 record = json.loads((root / path).read_text("utf-8")),没有走本模块的 _read(),跳过路径包含检查、符号链接拒绝与 4 MiB 上限。
  • 补一处 @david6666666 与 Amy 都没点到的:external_read 分支用 receipt = {key: record[key] for key in ("locator", "page")} 和 record["revision"] / record["card_sha256"] / record["page"] 直接下标取值,缺字段是未捕获的 KeyError 而不是校验后的明确拒绝,且 page 为整数、revision 40-hex、card_sha256 64-hex 都没有校验;视图里 citation.page?…+citation.page:null 对非标量同样静默退化。注意真正的读取路径 round_knowledge.search() 反而做了这些校验(locator 相对性、card_sha256 64-hex、revision 40-hex),所以问题恰好只在“投影信任记录而不信任读取器”这一段。
  • 现有回归没有覆盖它:tests/test_optimization_session.py 最后那段 import 注入只改 record["text"] 和 record["items"][0]["summary"],这两个键都不在投影白名单内,所以测试通过而漏洞仍在。

怎样才解除阻塞(三项,前面两项就在本 PR 内):

  1. 用当前视图再生并提交 docs/examples/dashboard-profile-review.html,让 test_published_profile_example_matches_fixture 在 3.10 / 3.11 变绿。
  2. 投影前对白名单标量做类型/格式校验(count 非负整数、state/platform/score_scale 字符串、elapsed_ms 数值、revision 40-hex、card_sha256 64-hex、page 正整数),并把 context / receipt 的读取改到 _read()。
  3. 扩展已有回归:畸形 count / page、根目录之外的 context 路径,各一条。

关于当前 head 上的 @zengchuang-hw Approve:我看到了,它没有覆盖 red CI 和上述投影校验缺口,PASS 要求无未解除阻塞,所以我不会翻转结论。

非阻塞、随作者下次 push 一起处理的协调项:#516 已进 main,需 rebase 到当前 main 并复核受管轮次仍能从更新后的目录捕获本地知识、读取钉住的 CANNBot 结果;若 #526 先合,后合一方把 round_knowledge.py 及相关导入迁到 apps.integrations.cannbot。

推送新的 head 后我会增量重读 delta。本轮只读了完整 diff 与 #523 的 body / 线程 / 正式评审,没有执行测试、浏览器用例、生产 grant 或昇腾实机验证。

— Dong-bot(授权代理)

Record opt-in CANNBot searches and pinned read receipts beside local captures. Show metadata and explicit citations in Dashboard, preserve native local capture verification, and reserve final evaluation time when the external worker times out.

Signed-off-by: jiangkuaixue123 <jiangxiaozhou111@163.com>
Agent-assisted-by: Codex / implement_523 (implementer)

Copy link
Copy Markdown
Collaborator

PR review verdict — DO NOT PASS

增量检视上一轮 head 8bbc58ccbb05fee2b0ad2f44209a7badea9732b2 到当前 head 24f5e08a0d600721e59f0734ffa1c66fb2cb0bca(已 rebase 到当前 main f0e92e8d4992746ac62e89f16347ecab6141de67,round_knowledge.py 现位于 apps.integrations.cannbot)。当前 head 上仍有未解除的阻塞,因此暂不 Approve。

已修好的部分:

  1. 已重新生成并提交 docs/examples/dashboard-profile-review.html,与 round_decision_view.html 中的 managedRetrieval() / knowledgeUses() 对齐。
  2. 外部检索/读取投影已做标量类型与格式校验(search_metadata / read_metadata:count 为整数、revision 40-hex、card_sha256 64-hex、page 为正整数等),外部记录已改走 _read()。tests/test_optimization_session.py 也覆盖了畸形 count / page 等 allowlist 字段。

仍未解决:

  • 本地 delivered_context 仍不走 _read()。 src/inferrsi/apps/views/retrieval_projection.py 的 managed_knowledge() 第 323 行仍是 json.loads((root / path).read_text("utf-8")),因此继续跳过路径包含检查、符号链接拒绝和 4 MiB 上限,也不对照 reference["sha256"]。请把这条读取改到 _read(),并补一条根目录之外(或越界相对路径)的 context 回归。

本轮只读了相对上一 head 的增量与相对当前 main 的完整 20 个文件 diff,没有执行测试套件、生产 grant 或昇腾实机验证。

Use the contained regular-file reader and verify the retained SHA-256 before consuming managed knowledge. Cover escaping paths, symbolic links, the capture byte limit, and digest mismatch through the Dashboard.

Signed-off-by: jiangkuaixue123 <jiangxiaozhou111@163.com>
Agent-assisted-by: Codex / implement_523 (implementer)

Copy link
Copy Markdown
Collaborator Author

@amy-why-3459 @david6666666 @Dong1017 @zengchuang-hw 麻烦复审 cc552e47。

这版修复了 Amy 最新指出的本地 delivered_context 读取。Dashboard 投影现在走 _read(),Harness 在首次读取时也校验路径、4 MiB 上限和留存 SHA-256。回归覆盖了越界路径、文件及父目录符号链接、超限和摘要不匹配。独立复审在新提交上通过 214 项定向测试和 Ruff,1 项依赖固定旧版 wheel 的测试跳过。最新评审意见

前一提交的 Python 3.10 / 3.11 全量检查、Chromium 和安装包检查均已通过。新提交的 GitHub CI 已触发。前一提交的 CI

如果复核通过,请在 GitHub 提交 Approve,正文第一行单独写 LGTM。

@Dong1017 Dong1017 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR review verdict — PASS
Reviewed base f0e92e8d4992746ac62e89f16347ecab6141de67 and head cc552e47bc5a707f715fcb36da91b7d42525e42f (full diff, diffComplete: true), plus the incremental step from the last formally reviewed head 24f5e08a, #523 body/thread, the seeded review record, and #522's goal and acceptance bullets.

All three blockers from my 8bbc58cc DO NOT PASS and the single remaining blocker in @amy-why-3459's 24f5e08a review are resolved on this head.

Fixed in cc552e47

  1. Local delivered_context now uses the bounded reader. Amy's finding was that managed_knowledge() still did json.loads((root / path).read_text("utf-8")) for local captures. In this diff _read() delegates to bounded_record_bytes(root, relative, MAX_CONTEXT_CAPTURE_BYTES) (retrieval_projection.py), so the local path now gets the same treatment as external records: non-string/empty names, \ and : rejected, absolute and .. parts rejected, every path component checked for symlinks (so ancestor symlinks are covered, not only the final file), inside() containment, and file_absent / too_large / unsafe_path states instead of silent parsing. managed_knowledge() now calls that one _read() for every kind and requires digest == reference["sha256"] before projecting, so a matching digest is necessary but no longer sufficient.
  2. Harness first access is bounded too. harness/optimization.py adds _read_context(), which reads through bounded_record_bytes and compares SHA-256 against the retained reference; _load() uses it for every retained context (replacing the unbounded (root / context["path"]).read_bytes()), and capture_context() uses it for the returned context. The diagnosis-binding check is correctly skipped for external_search / external_read, which are stored without diagnosis_id.
  3. Regression coverage matches the claim. test_managed_knowledge_rejects_unverified_capture is parametrized over absolute, outside (../), symlink, ancestor_symlink, oversized, hash_mismatch; it asserts the projection returns ([], {}), asserts read_regular is never reached for unsafe paths, and asserts too_large is enforced at the MAX_CONTEXT_CAPTURE_BYTES boundary. That is the "context path outside the root" case Amy asked for, not a restatement of it.

Earlier findings, re-checked in this diff rather than taken from the review record

  • Published example page: docs/examples/dashboard-profile-review.html is in this diff and carries the same managedRetrieval() / knowledgeUses() additions and the same numbers / contextIds / results-branch edits as src/inferrsi/apps/views/round_decision_view.html. The deterministic cause of the 3.10/3.11 test_published_profile_example_matches_fixture failure (run 44545533153) is therefore fixed by construction, not by re-running.
  • Unvalidated metadata pass-through: external projection now goes through search_metadata() / read_metadata() with allowlisted types — count an int bounded below by retained items and at 200, revision 40-hex, card_sha256 64-hex, page a positive int, score a finite number or None, state from CHANNEL_STATES, platform from PLATFORMS, locator relative and regex-checked. external_read no longer bare-subscripts record[...] (my KeyError point), and a receipt is only linked when its search_ref resolves to a search in the same round with matching revision, locator and digest. The new assertions on the malformed-record block check the exact surviving key set and that count / revision / score_scale / elapsed_ms degrade to None instead of carrying nested objects.
  • Attribution: _load() compares a completed round's knowledge_refs and contexts with the SHA-256-verified observation and re-checks each cited path against the submitted context snapshot; the tests exercise replacing an earlier candidate's refs, appending a later receipt, and rewriting a retained receipt with its state hash updated (Round knowledge attribution… / Cited knowledge context differs…).
  • Degradation check David asked for on #522 is present: test_cannbot_timeout_keeps_local_ranking_and_final_budget asserts the channel timeout budget is _knowledge_time − _WORKER_CLEANUP_SECONDS, the deadline is unchanged, local refs and ordering are identical to the local-only run, a candidate citing only the local item settles, and final still completes.
  • Retention: the test asserts card text, worker diagnostics and the private locator path appear in neither the Dashboard payload nor any retained JSON under the session root, and the query is redacted before search and retention, matching #522's allow-list bullet.

Non-blocking follow-ups

  • managed_knowledge() still indexes record["contexts"], record["items"], record["request"] and item ["ref"] / ["resources"] directly for delivered_context. A malformed local capture with a matching digest raises an uncaught KeyError in the Dashboard projection instead of a typed rejection. It fails visibly rather than widening the view, so I do not treat it as blocking, but a guard would match the external path's style.
  • #516 integration is done in this head (round_knowledge.py and its imports live under apps.integrations.cannbot, and docs/apps-module-migrations.json lists the new consumers). @zengchuang-hw's ordering note still stands if #526 lands after this.
  • #522 remains open for requester acceptance, and production CANNBot grant plus Ascend workload verification are still open. Both are outside this code verdict.

Not verified here: I did not execute the test suite, the Chromium/Playwright cases, a production grant or Ascend hardware; exact-head CI for cc552e47 was only reported as triggered, so I read the fixture/example consistency from the diff. The preceding head 24f5e08a had both full-check jobs, Chromium and the installed-package check green (run 44707929174). The 214-test and Ruff result on this head is the author's report, not my run.


Posted by Dong-bot, an automated agent acting on behalf of @Dong1017 (always-on-bot, model claude-sonnet-5-5).

@Dong1017 Dong1017 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR review verdict — DO NOT PASS

复审 #523:base f0e92e8d4992746ac62e89f16347ecab6141de67 → head cc552e47bc5a707f715fcb36da91b7d42525e42f,重点核对 24f5e08a..cc552e47 和 #522 的软件交付范围。当前 head 没有正式 APPROVED,也没有未解除的 CHANGES_REQUESTED;旧 head 的 Approve 已被撤销,不计入本轮。

阻塞:当前 head 的必需 CI 尚未有通过记录。 Python 3.10/3.11 full-check、Chromium 和安装包结果 属于 24f5e08a。cc552e47 修改的是 Dashboard 与 Harness 共用的记录读取路径。PR 正文报告当前 head 的 214 项定向测试和 Ruff 已通过(1 项旧 wheel 兼容测试跳过),但我将当前提交的必需 CI 通过作为本次 Approve 的前置条件,因此本轮只提交 COMMENT。请补上 cc552e47 的必需检查结果;如有新 push,我会按新 head 复查。

此前代码阻塞已解除。 Diff 中 managed_knowledge() 对本地 delivered_context 也走 _read(),并比较留存 SHA-256;Harness 的 _load()、首次捕获返回及条目引用查找共用 _read_context()。两侧共用的 bounded_record_bytes() 拒绝绝对或越界路径以及文件或祖先目录符号链接,并限制读取为 4 MiB 加一个用于判断超限的字节。新增参数化回归覆盖这些路径、超限和摘要不匹配。发布示例已再生,外部搜索和回执的标量校验及关联检查仍在,纯本地响应仍是三字段 reference,已完成引用仍与校验过的 observation 和提交时的上下文快照绑定。

本轮仅做静态核对,没有重跑测试、浏览器、生产 grant 或昇腾工作负载。生产验证和 #522 的请求方验收不属于本轮阻塞。


Posted by Dong-bot, an automated agent acting on behalf of @Dong1017 (always-on-bot, model gpt-6.2-sol).

@jiangkuaixue123
jiangkuaixue123 enabled auto-merge (squash) November 20, 2026 09:30

@amy-why-3459 amy-why-3459 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR review verdict — PASS
增量检视上一轮 head 24f5e08a0d600721e59f0734ffa1c66fb2cb0bca 到当前 head cc552e47bc5a707f715fcb36da91b7d42525e42f(base f0e92e8d4992746ac62e89f16347ecab6141de67)。

上一轮留下的阻塞已解除:managed_knowledge() 对本地 delivered_context 也走 _read(),并对照 reference["sha256"]。_read() 现在经 bounded_record_bytes() 拒绝绝对或越界路径、文件及祖先目录符号链接,并限制读取为 MAX_CONTEXT_CAPTURE_BYTES。Harness 的 _load()、首次捕获返回、外部搜索读取和条目引用查找共用 _read_context()。test_managed_knowledge_rejects_unverified_capture 覆盖了 absolute / outside / symlink / ancestor_symlink / oversized / hash_mismatch。

此前已修好的部分在本 head 仍然成立:发布示例已再生,外部检索/读取有标量类型与格式校验,纯本地响应仍是三字段 reference,已完成引用仍与校验过的 observation 和提交时的上下文快照绑定。

这是路径安全与记录读取的修复,不改变模型输出或性能路径,不需要准确率/性能对照实验。架构上复用已有的 bounded reader,测试是针对上一轮缺口的定向回归,没有重复堆叠。

提交前已重新拉取本 head 的 review 与评论:@Dong1017 已在 5990392804 对本 head Approve;5990416879 的 DO NOT PASS 仅因当时必需 CI 尚未出结果。当前 Ready CI 44709987715 上 full-check 3.10/3.11、installed-package、dashboard-browser、pr-references 以及 knowledge-model-policy 均为 success,该项已解除。无未解除的 CHANGES_REQUESTED。本轮只读了 24f5e08a..cc552e47 的 4 个文件增量,没有重跑测试套件、生产 grant 或昇腾实机验证。生产验证和 #522 的请求方验收不属于本轮阻塞。

@jiangkuaixue123
jiangkuaixue123 merged commit 6bdc86e into main Nov 20, 2026
12 checks passed
@Dong1017

Copy link
Copy Markdown
Collaborator

Posted by an agent on behalf of @Dong1017 (incremental review only; items already raised by others are not repeated).

Incremental review of 24f5e08a → cc552e47: no new items. I found nothing to add to what @amy-why-3459 (5990575721), @Dong1017 (5990392804, 5990416879) and the author (7035608214) have already covered, so this comment records what I verified rather than restating them.

Note the timing: #523 was merged at 09:40Z, before this review started. The head has not moved since cc552e47, and merge commit 6bdc86ee carries an identical tree (270b553b), so this reading applies to what is now on main.

Verified here

  • Exact-head CI on cc552e47 is green, which is the one condition @Dong1017 kept open in 5990416879: full-check (3.10) and full-check (3.11) completed at 09:37Z–09:38Z, and installed-package (3.10, 3.11), dashboard-browser, pr-references, lint-and-smoke and declarations are all success.
  • Locally at cc552e47, tests/test_optimization_session.py gives 34 passed, 1 skipped — the skip is tests/test_optimization_session.py:889, the pinned pre-move wheel runtime, which is the one the author reported. The six new test_managed_knowledge_rejects_unverified_capture cases are included in that pass.
  • Read the new reader end to end rather than taking the description: bounded_record_bytes (src/inferrsi/harness/records/evidence.py:160) rejects non-string and empty names, \ and :, absolute and .. parts, checks every path component for a symlink — so an ancestor symlink is caught, not just the leaf — and re-checks containment; read_regular then opens with O_NOFOLLOW and rejects anything that is not a regular file. Both _read (apps/views/retrieval_projection.py:79) and _read_context (harness/optimization.py:96) bound the read at MAX_CONTEXT_CAPTURE_BYTES and compare the retained digest before anything is projected.

One non-blocking observation, not raised previously

The 4 MiB bound is now applied on read while the write side has no matching bound. _store_knowledge (src/inferrsi/harness/optimization.py:346) writes external_search / external_read records through atomic_write_json with no size check, whereas both readers refuse anything above MAX_CONTEXT_CAPTURE_BYTES. A record written above the bound would afterwards make _load() fail rather than degrade, which turns a write-side gap into an unopenable campaign.

It is not reachable on this head, so I am not treating it as a defect: search_metadata (apps/integrations/cannbot/round_knowledge.py:30) allowlists the fields and caps items at 200 scalar entries, and the CANNBot worker's stdout is capped at 2 MiB (apps/integrations/cannbot/project.py:22). A write-side guard would only matter if that record shape grows; the two ends are otherwise symmetric today.

Scope: read the API diff 24f5e08a..cc552e47 (three source files plus one test file), compared the merge commit's tree with the head tree, read the exact-head check runs, and ran tests/test_optimization_session.py at cc552e47 on Python 3.12. Did not run the full suite on 3.10/3.11, the Chromium job, a production grant, or any Ascend workload.

BeatSeat added a commit to BeatSeat/InferRSI that referenced this pull request Nov 20, 2026
…atrixLab#519/InferMatrixLab#521/InferMatrixLab#523

Rounds now require a retained bottleneck diagnosis (InferMatrixLab#519), so the explanation
tests record one before candidate rounds. The combined declaration test cites
both a delivered context and a InferMatrixLab#523 path#item-ref and checks that the round,
its retained observation and the dashboard keep the citations, the diagnosis
binding and the bound mechanism together through final.

InferMatrixLab#523 labels a round's measured score with metric_key, which this change names
after the measured metric. Under --decision paired the score is the median
paired speedup, so managed rows carry score_key (the frozen selection metric)
and the round view prefers it; legacy rows fall back to metric_key.

Service-reuse profiling is optional since InferMatrixLab#521; the docs and the start-time
comment say its receipts are not inputs to the paired/explanation switches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>
BeatSeat added a commit to BeatSeat/InferRSI that referenced this pull request Nov 20, 2026
…atrixLab#519/InferMatrixLab#521/InferMatrixLab#523

Rounds now require a retained bottleneck diagnosis (InferMatrixLab#519), so the explanation
tests record one before candidate rounds. The combined declaration test cites
both a delivered context and a InferMatrixLab#523 path#item-ref and checks that the round,
its retained observation and the dashboard keep the citations, the diagnosis
binding and the bound mechanism together through final.

InferMatrixLab#523 labels a round's measured score with metric_key, which this change names
after the measured metric. Under --decision paired the score is the median
paired speedup, so managed rows carry score_key (the frozen selection metric)
and the round view prefers it; legacy rows fall back to metric_key. The
published profile-review example is regenerated from its fixture.

Service-reuse profiling is optional since InferMatrixLab#521; the docs and the start-time
comment say its receipts are not inputs to the paired/explanation switches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>
Dong1017 pushed a commit that referenced this pull request Nov 21, 2026
)

* harness: report paired AB/BA statistics alongside the point verdict

Pair the k-th baseline and candidate samples that steps() already
alternates, and report the median paired speedup with a seeded percentile
bootstrap interval and its relation to the frozen gate. The field is
report-only: verdict, eligibility and selection are unchanged, and any value
that cannot be computed is reported as unavailable so records stay strict
JSON. Fewer than five pairs report no interval because simulated coverage at
three pairs is about 75%. tools/measurement_simulation.py reproduces the
synthetic ablation.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Agent-assisted-by: Codex CLI / gpt-6.1-sol [effort=high] (review)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: explain gains with profile evidence and opt-in decision switches

Measurement scripts may add per-step region breakdowns and work counters.
A round may declare its mechanism and expected region/counter directions.
Regions declared unchanged act as an in-step clock, so ratios to them and
their share of the step total cancel device-wide clock or thermal drift;
counters such as launches or DRAM bytes show whether a small gain is
reproducible. Directions come only from paired intervals, with no
repository-wide tolerance.

Two switches are frozen at campaign start and default to the existing
behaviour: --require-explanation adopts only candidates whose mechanism is
confirmed by the data, and --decision paired requires the paired interval
to clear the gate, failing within-noise rounds without blocking the search.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: bind declared mechanisms before execution and harden profile evidence

Bind the round's mechanism into control state before the candidate runs and
assess against that copy, so a candidate cannot rewrite its own declaration.
Require five pairs before any profile direction, treat zero-baseline ratios as
undefined, report unavailable shares instead of raising, keep raw evidence for
every region, and never normalize declared references against each other.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Agent-assisted-by: Codex CLI / gpt-6.1-sol [effort=xhigh] (review)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: judge the in-memory declaration and seal its digest

The candidate runs with the caller's privileges and can write state.json or
the attempt copy. Pass the declaration held since submission to the assessor,
record its digest, and treat a copy that no longer matches as an integrity
failure.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Agent-assisted-by: Codex CLI / gpt-6.1-sol [effort=xhigh] (review)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: do not trust a declaration recovered after interruption

An interrupted attempt is settled by a new process that can only read files
the candidate could write. Settle it without the declaration, mark the record,
and leave require_explanation to keep the round unadopted.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Agent-assisted-by: Codex CLI / gpt-6.1-sol [effort=xhigh] (review)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: document switch precedence and the paired-only decision

With both switches on, --decision sets the performance verdict first and
--require-explanation only downgrades a PASS. The paired decision reads the
interval alone, so a candidate whose point estimate misses the gate but whose
paired interval clears it passes, with agrees_with_point_gate recorded false.
Regression tests pin both behaviors.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: exact paired intervals, Bonferroni checks and INCONCLUSIVE within noise

The percentile bootstrap lower bound for a median of n pairs is an order
statistic whose one-sided error exceeds 2.5% at small n (3.1% at 5 pairs,
6.25% at 7). Use the exact distribution-free order-statistic interval (the
inverted sign test) instead: the rank keeps each tail at or below 2.5%, so the
minimum is six pairs and A/A at the gate passes at most 2.5% of the time.

Declared expectations are judged as a family: region and counter intervals use
the Bonferroni confidence 1 - 5%/k, and too few pairs for it is unverifiable.
A declared-unchanged item is reported as not contradicted, never confirmed.

A paired interval that straddles the gate shows only that passing was not
demonstrated, which is not evidence that the gate was missed, so the round is
INCONCLUSIVE (within_noise) and still does not block the search. Records say
report_only: false when the interval decides the verdict.

Reported by linyueqian on #457.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: exact binomial arithmetic and report-only profile failures

A float 2 ** pairs overflows near a thousand pairs; compare binomial tails as
exact rationals instead. A failure while building profile evidence is reported
as unavailable rather than raised, so it cannot change the default verdict.

Found by Codex review of the exact-interval change.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Agent-assisted-by: Codex CLI / gpt-6.1-sol [effort=xhigh] (review)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: keep raw/normalized reversals and missing evidence inconclusive

When a region's raw and reference-normalized intervals point in opposite
definite directions, an absolute increase can read as a relative decrease
(two references can each cross 1 while their sum rises in every pair). No
declaration predicts a relative effect, so record raw_normalized_conflict and
leave that check unverifiable instead of letting the normalized sign win.

Under --require-explanation, only contradicted evidence fails. An unsupported
prediction is missing evidence, like a paired interval within noise, so it is
INCONCLUSIVE; the candidate is still not adopted and the search continues.

Reported by david6666666 on #454 and #457.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: refuse explanation gates that could never adopt a candidate

With --require-explanation, fewer than six repetitions give no interval for
any expectation, so every round would be unverifiable and nothing could be
adopted; campaign start now rejects that. A round whose declaration needs more
pairs than the frozen repetitions (Bonferroni over its expectations) is
rejected before execution, so it spends no budget. Without the switch a
declaration remains a report and is not restricted.

Reported by linyueqian on #457.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: rank paired-decision candidates by paired speedup

Under --decision paired the verdict read the paired interval, but adoption
still compared independent candidate medians, so a paired PASS could be
outranked and never reach final. The frozen selection is now the median
paired speedup against the baseline (1.0), and that same speedup is the
round's score, speedup and improvement. Point values stay in point_estimate.
Each round records why it was or was not selected. The default point mode
and benchmark sessions keep their selection.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: refuse paired and explanation switches in service-reuse campaigns

Service-reuse campaigns (#480) record neither AB/BA pairs nor per-step
profiles, so --decision paired, --require-explanation and --mechanism-file
would be silently ignored there. start and round now reject them.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: keep scoreless settlement to the project paired decision

A completed, ineligible round could settle without a score for any
assessor, which changed the packaged-task contract outside #454. Only a
project plan with the frozen paired decision may now omit the score (its
paired statistics can be unavailable). Packaged tasks and point-mode
projects still block on a missing score, as before.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* docs: say which service-reuse inputs the paired switches lack

Service reuse keeps its own profiling stage (#480); what it does not
produce are the AB/BA pairs and per-measurement breakdown/counters that
the paired decision and explanation checks read.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* apps: deliver no baseline speedup for a final without a score

The delivery projection (#485) reported 1.0 for a retained baseline
whenever the final completed. Under the paired decision, a final whose
statistics are unavailable completes without a score, and the controller
summary already reports no speedup for it. The delivery bundle now
agrees. Also covers #501's --strategy/--knowledge-ref alongside a bound
mechanism on one round and its final.

Agent-assisted-by: Claude Code / claude-opus-5-5 (author)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

* harness: keep mechanism and knowledge citations together after #519/#521/#523

Rounds now require a retained bottleneck diagnosis (#519), so the explanation
tests record one before candidate rounds. The combined declaration test cites
both a delivered context and a #523 path#item-ref and checks that the round,
its retained observation and the dashboard keep the citations, the diagnosis
binding and the bound mechanism together through final.

#523 labels a round's measured score with metric_key, which this change names
after the measured metric. Under --decision paired the score is the median
paired speedup, so managed rows carry score_key (the frozen selection metric)
and the round view prefers it; legacy rows fall back to metric_key. The
published profile-review example is regenerated from its fixture.

Service-reuse profiling is optional since #521; the docs and the start-time
comment say its receipts are not inputs to the paired/explanation switches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>

---------

Signed-off-by: BeatSeat <137616995+BeatSeat@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:task Bounded delivery task with a delegated slice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants