USD PointInstancerAlgo : Support orientationsf attribute - #1560
Open
johnhaddon wants to merge 1 commit into
Open
USD PointInstancerAlgo : Support orientationsf attribute#1560johnhaddon wants to merge 1 commit into
orientationsf attribute#1560johnhaddon wants to merge 1 commit into
Conversation
This is a float-precision version of the original half-precision `orientations` attribute. A separate attribute name is needed in USD because USD attributes are strongly typed. But Cortex primitive variables can take any data type so we stick with our standard `orientation` name regardless of type. This avoids any ambiguity about which attribute takes precedence.
Collaborator
|
LGTM. You may have already seen this, but USD provides UsesOrientationsf, which may be preferable to our own fallback, but I'm good either way... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a float-precision version of the original half-precision
orientationsattribute. A separate attribute name is needed in USD because USD attributes are strongly typed. But Cortex primitive variables can take any data type so we stick with our standardorientationname regardless of type. This avoids any ambiguity about which attribute takes precedence.This PR is for Cortex 10.6, destined for a Gaffer 1.6 patch version. For 10.7/1.7 we should also decide what to do when writing PointInstancers to USD. I'm inclined to always write to
orientationf, but perhaps we'll want to gate it with an environment variable?