Repository navigation
fix: skip plugin entry points that fail to load - #7
Closed
Golden007-prog wants to merge 1 commit into
Closed
Golden007-prog wants to merge 1 commit into
Golden007-prog wants to merge 1 commit into
Conversation
Contributor
|
This issue has been solved by my own changes before i saw your PR, thanks for your interest in the tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed importer or exporter entry-point import currently stops parser construction, so even the built-in
linkandcheckcommands fail. Catch each individual load failure, print a warning naming the entry point, group and cause, and continue discovering healthy plugins.Fixes #4.
The existing rejection of loaded objects that are not valid plugin subclasses remains unchanged. This patch handles failures raised by
entry_point.load().Validation on Windows/Python 3.14.3:
link/checkcommands with a broken plugin in either group.python -m pytest tests/test_exporter.py tests/test_importer.py tests/test_cli.py -q: 36 passed.python -m pytest -q: 133 passed.git diff --check: passed.uv build: source distribution and wheel built successfully.Prepared with OpenAI Codex assistance; source and regression tests reviewed before publication.