fix(dim): reject attribute names with colons on deletion - #317
Merged
Merged
Conversation
- Prevent silent failure when a user mistakenly passes a colon-separated key-value pair to 'remove attrs' (e.g. 'remove attrs key:value') by raising an exception in 'WithAttr.delete_attrs'. - Add comprehensive unit/integration test coverage in 'dim-testsuite/tests/pool_test.py' to verify that trying to delete an attribute containing a colon raises an Exception. - Document this change in 'dim/CHANGES'. Co-authored-by: Gemini <gemini@local>
eschweikert
requested review from
akaramimotlagh and
miesi-ionos
and removed request for
akaramimotlagh
August 19, 2026 12:21
Collaborator
|
Please add testcases. Please also add a testcase for $ ndcli list pool de-kae-bs-po-generalqa-fe-int-312-qa_v4 rights to be able to revoke attr.audit. |
…eletion - Add end-to-end CLI integration test cases in 'dim-testsuite/t/pool-list-rights.t' for pool attr rights trailing-dot revoke and prefix symmetry. - Add test case in 'dim-testsuite/t/pool-list-rights.t' for the new colon-rejection validation when removing attributes. Co-authored-by: Gemini <gemini@local>
Collaborator
|
The tests are correct. The code changes slipped in somewhere else? Ok, lets go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes ndcli modify pool <P> rmove attrs a:v does not remove attribute #111