fix(dim): fix pool attr right revoke with dots - #316
Merged
Merged
Conversation
eschweikert
commented
Aug 19, 2026
eschweikert
commented
Collaborator
- Resolve an issue where revoking an 'attr' right with trailing or leading dots (e.g., 'attr.audit.') would fail silently because the DB query searched for 'attr' instead of the full attribute right string.
- Make 'group_grant_access' and 'group_revoke_access' symmetric and robust by automatically handling both stripped (e.g., 'audit.') and prefixed (e.g., 'attr.audit.') inputs for the 'attr' right type.
- Add comprehensive integration tests in 'dim-testsuite/tests/rights_test.py' covering all edge cases (with/without dot, prefix robustness, and independence between rights).
- Resolve an issue where revoking an 'attr' right with trailing or leading dots (e.g., 'attr.audit.') would fail silently because the DB query searched for 'attr' instead of the full attribute right string. - Make 'group_grant_access' and 'group_revoke_access' symmetric and robust by automatically handling both stripped (e.g., 'audit.') and prefixed (e.g., 'attr.audit.') inputs for the 'attr' right type. - Add comprehensive integration tests in 'dim-testsuite/tests/rights_test.py' covering all edge cases (with/without dot, prefix robustness, and independence between rights). Co-authored-by: Gemini <gemini@local>
Co-authored-by: Gemini <gemini@local>
eschweikert
force-pushed
the
bugfix/revoke-attr-dot
branch
from
August 19, 2026 12:06
12b35d8 to
b692a13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.