Skip to content

feat(ask-demo): the DNS question says the records are in AWS, and names GCP from the rows - #1233

Merged
lex00 merged 1 commit into
mainfrom
feat/ask-demo-dns-words
Nov 19, 2026
Merged

lex00 merged 1 commit into
mainfrom
feat/ask-demo-dns-words

Conversation

@lex00

@lex00 lex00 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Closes #1232

  • Reading line for dns-cross-cloud: "Our DNS is in AWS Route 53, so I'll start from those records and follow what they point at into other clouds."
  • Headline: "2 domains with DNS in AWS depend on 4 GCP resources". A new |cloud placeholder filter takes a resource kind's first segment (GCP::Compute::Address is "GCP") and refuses a value that isn't a kind. It has a unit test.
  • just ask-demo-refill changed only those two fields in narration.json. The fixture's DNS turn now returns kind, as the real query does.

just check passes.

@lex00
lex00 enabled auto-merge November 18, 2026 23:59
@lex00
lex00 added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 7ee49d4 Nov 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ask demo: the DNS question says the records are in AWS, so GCP results read right

1 participant