Fix L3 CDFs Logical_source_description - #202
Merged
leowerneck merged 6 commits intoSep 25, 2026
Merged
leowerneck merged 6 commits into
leowerneck merged 6 commits into
Conversation
leowerneck
added
bug
jaredclaypoole
approved these changes
Sep 15, 2026
jaredclaypoole
left a comment
jaredclaypoole
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
jaredclaypoole
approved these changes
Sep 15, 2026
jaredclaypoole
left a comment
jaredclaypoole
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Good call on fixing the trailing whitespace issues in this directory.
leowerneck
added
Ins: SWAPI
leowerneck
force-pushed
the
3438--fix-l3-cdfs-logical-source-description
branch
from
September 15, 2026 20:46
6c2415a to
13c2e1e
Compare
jtniehof
requested changes
Sep 22, 2026
jtniehof
left a comment
jtniehof
left a comment
Collaborator
There was a problem hiding this comment.
I think we're good other than the mapper names.
leowerneck
force-pushed
the
3438--fix-l3-cdfs-logical-source-description
branch
from
September 22, 2026 20:20
13c2e1e to
61e830a
Compare
jtniehof
approved these changes
Sep 23, 2026
jtniehof
left a comment
jtniehof
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I'll give Luisa a chance to look before merging.
leowerneck
merged commit Sep 25, 2026
8c03a5e
into
IMAP-Science-Operations-Center:main
16 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Closes #199.
Overview
Fix IMAP datasets names to include the pattern:
I have also confirmed that all descriptions don't end in periods. I would note that, in the case of L3, the descriptions are multi-lined (typically 3 lines), but they still don't end in periods.
File Changes
The following changes were made:
<instrument> -> IMAP Mission <instrument>):imap_l3_processing/cdf/config/imap_swe_l3_global_cdf_attrs.yamlimap_l3_processing/cdf/config/imap_swapi_l3b_global_cdf_attrs.yamlimap_l3_processing/cdf/config/imap_swapi_l3a_global_cdf_attrs.yamlimap_l3_processing/cdf/config/imap_lo_l3_global_cdf_attrs.yamlimap_l3_processing/cdf/config/imap_hit_l3_macropixel_global_cdf_attrs.yamlimap_l3_processing/cdf/config/imap_hit_l3_direct-events_global_cdf_attrs.yamlIMAP <instrument> -> IMAP Mission <instrument>):imap_l3_processing/cdf/config/imap_hi_l3_global_cdf_attrs.yamlimap_l3_processing/cdf/config/imap_ultra_l3_global_cdf_attrs.yamlNote
A bit out-of-scope, but this PR also cleans up lines ending in whitespace in
imap_l3_processing/cdf/config. Should require minimal effort to review, though.