Repository navigation
Developer docs with the release process; version set in one place - #2
Merged
Merged
Conversation
tests/test_version.c compares nx_version() with numpy2x_VERSION from CMake instead of a literal. The wheels workflow gets a first job that fails a tag run unless the tag is v<version of CMakeLists.txt>; wheels and sdist wait for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JT2yHm85oFjgf1AcgGLUux
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JT2yHm85oFjgf1AcgGLUux
…tail Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JT2yHm85oFjgf1AcgGLUux
Member
Author
|
leave out contributions for now (not decided yet, TODO) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JT2yHm85oFjgf1AcgGLUux
Member
Author
|
Done: Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change, a new release takes one edited line plus a tag. Change
project(numpy2x VERSION x.y.z ...)inCMakeLists.txt, merge, then push the tagvx.y.z.docs/development.mdnow documents the whole developer workflow. New sections:main, Linux/Windows parity, the C ABI, formatting;wheelsworkflow does, PyPI rules, re-running on a tag, new Python versions.The existing build, test, benchmark and Docker sections are unchanged.
tests/test_version.ccomparesnx_version()withnumpy2x_VERSIONfrom CMake (a compile definition). Before, it compared against a hard-coded literal, so every version bump had to edit this file as well.wheels.ymlgets a new first job,version. On tag runs it fails unless the tag isvfollowed by the version inCMakeLists.txt. The wheels and sdist jobs wait for it, so a wrong tag stops the run before anything is built or uploaded. The first 1.0.0 attempt had exactly this problem: wheels versioned 0.1.0 under the tagv1.0.0. On pull requests and manual runs that are not on a tag, the check is skipped.Checked locally:
versionctest passes (Linux, Release).sedextracts1.0.0fromCMakeLists.txtand matchesv1.0.0.This PR touches
wheels.yml, so the wheels workflow runs on it too (without the tag check).🤖 Generated with Claude Code
https://claude.ai/code/session_01JT2yHm85oFjgf1AcgGLUux