TestQuestionPool 47888: Fix Formula Question Scoring Tab Exception - #12112
Closed
matheuszych wants to merge 1 commit into
Closed
matheuszych wants to merge 1 commit into
matheuszych wants to merge 1 commit into
Conversation
See: https://mantis.ilias.de/view.php?id=47888 The scoring tab expected `sign`, `value`, and `unit` keys from `assFormulaQuestionResult::getResultInfo()`, but simple rating mode returned only `points`, which caused an exception when rendering result details. Ensured a consistent result array shape, tightened unit checks with `instanceof`, and simplified the rated result text output in `assFormulaQuestion`.
Contributor
Author
|
Needs to be cherry-picked into ILIAS 10 and ILIAS 11 as well. |
Contributor
|
Hi @matheuszych ! Thanks for the PR, but please always provide PRs to the lowest version needing the fix. Picking downwards is always very dangerous! I close this for the time being. Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=47888
The scoring tab expected
sign,value, andunitkeys fromassFormulaQuestionResult::getResultInfo(), but simple rating mode returned onlypoints, which caused an exception when rendering result details. Ensured a consistent result array shape, tightened unit checks withinstanceof, and simplified the rated result text output inassFormulaQuestion./cc @thojou