Test 46869: Validate Random Set Taxonomy Filters - #12111
Open
matheuszych wants to merge 2 commits into
Open
matheuszych wants to merge 2 commits into
matheuszych wants to merge 2 commits into
Conversation
See: https://mantis.ilias.de/view.php?id=46869 Random question set taxonomy filters could be loaded or mapped with invalid taxonomy ids, which produced broken staging queries. `setMappedTaxonomyFilterFromDbValue()` now unserializes with restricted classes, rejects non-array payloads, and delegates to `setMappedTaxonomyFilter()`, which drops invalid entries. `mapTaxonomyFilter()` ignores mapped taxonomy ids below 1; `ilTestRandomQuestionSetBuilder`, `addTaxonomyFilter()`, and the staging query builder skip non-positive ids when applying filters.
See: https://mantis.ilias.de/view.php?id=46869 Random question set builder classes still used camelCase for properties and local variables. Rename them to snake_case so they follow the ILIAS coding style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=46869
Random question set taxonomy filters could be loaded or mapped with invalid taxonomy ids, which produced broken staging queries.
setMappedTaxonomyFilterFromDbValue()now unserializes with restricted classes, rejects non-array payloads, and delegates tosetMappedTaxonomyFilter(), which drops invalid entries.mapTaxonomyFilter()ignores mapped taxonomy ids below 1;ilTestRandomQuestionSetBuilder,addTaxonomyFilter(), and the staging query builder skip non-positive ids when applying filters.Random question set builder classes still used camelCase for properties and local variables. Rename them to snake_case so they follow the ILIAS coding style.
/cc @thojou