Skip to content

Server side tests - #1347

Merged
adkinsrs merged 12 commits into
develfrom
server-side-tests
Oct 13, 2026
Merged

adkinsrs merged 12 commits into
develfrom
server-side-tests

Conversation

@adkinsrs

@adkinsrs adkinsrs commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Performed UI checks and additional bug fixes found in this

https://claude.ai/artifact/YHj5Vd4FekFDjGuSp8HmGn?sk=5wm2eLfvzJz3uzoJxBhWag

I had Claude run through and create 3 phases of server-side tests and fix any bugs or vulnerabilities encountered when scanning through to do the primary task

  • Phase 1 - Security patches
  • Phase 2 - Regression tests for closed github issues. I am sure it did not catch everything and it did not address the private gEAR Github repo, but this gives us a good start
  • Phase 3 - Code coverage on server-side routes.

- Mark slow tests in `test_colorblind.py` for better test management.
- Update regression test in `test_regressions_lib.py` to ensure sensitive data is not returned.
- Improve error handling in `tsne_data.py` to raise exceptions for invalid orders or filters.
- Refactor `add_display_to_layout.cgi` to improve permission checks and layout member management.
- Validate PubMed IDs in `get_citation_from_pubmed_id.cgi` to prevent malformed requests.
- Remove deprecated `get_session_info.cgi` and `login.cgi` scripts for cleaner codebase.
- Add domain control in `save_new_genecart_json.cgi` to restrict domain list creation to admins.
- Implement email validation in `save_user_account_changes.cgi` to prevent duplicate accounts.
- Enhance layout selection logic in `save_user_chosen_layout.cgi` to ensure proper user permissions.
- Improve event registration logic in `set_user_event_registration.cgi` for better user feedback.
- Update analysis class in `analysis.js` to streamline analysis type handling and button visibility.
- Refactor workbench script to simplify analysis type checks and improve user notifications.
- Enhance user profile script to provide clearer error messages during preference updates.
@adkinsrs

Copy link
Copy Markdown
Member Author

@copilot generate a summary of the changes

Copilot AI commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@copilot generate a summary of the changes

The 11 commits add broad Python server-side coverage across API resources, CGI endpoints, library helpers, regressions, and workbench flows, with shared fakes and test setup. They also fix issues uncovered by those tests, including validation and permission checks, auth/account and layout handling, API/CGI error handling, analysis/workbench behavior, and several plotting/spatial/project helpers. Additional changes update testing/API documentation, adjust CI/test configuration, remove deprecated login/session CGI scripts, and make a few UI/content fixes.

@adkinsrs
adkinsrs merged commit 937a1ae into devel Oct 13, 2026
2 checks passed
@adkinsrs adkinsrs mentioned this pull request Oct 13, 2026
1 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants