root - chore: defense - record repository lockdown as applied - #77
Conversation
Repo admin applied lockdown-repo.sh (PRs required on main, tag ruleset, immutable releases, fork-PR approval, read-only tokens, Actions allowlist, secret scanning, Dependabot off). Do not commit the script. Leave Socket, npm secrets, and (manual) items unchecked. Co-authored-by: Jared Wray <me@jaredwray.com>
Co-authored-by: Jared Wray <me@jaredwray.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the repository's security documentation by marking the repository lockdown task as completed in DEFENSE_IN_DEPTH.md and adding detailed explanations of the active lockdown measures in SECURITY.md. The review feedback identifies a discrepancy between the allowed actions documented in SECURITY.md and the command-line parameters recorded in DEFENSE_IN_DEPTH.md, suggesting they be aligned for consistency.
| - [ ] Phishing-resistant 2FA (passkeys / hardware keys) on the GitHub and npm accounts (manual) | ||
| - [ ] Recovery codes stored offline in a password manager (manual) | ||
| - [ ] `lockdown-repo.sh` applied by a repo admin (never committed to this repo); `--check` with `--required-checks` and `--allowed-actions` passes (PRs required on the default branch, merges blocked unless required status checks pass, tag ruleset, immutable releases, fork-PR approval (public repos), read-only workflow tokens, Actions allowlist, secret scanning, Dependabot disabled, private vulnerability reporting (public repos)) | ||
| - [x] `lockdown-repo.sh` applied by a repo admin (never committed to this repo); `--check` with `--required-checks` and `--allowed-actions` passes (PRs required on the default branch, merges blocked unless required status checks pass, tag ruleset, immutable releases, fork-PR approval (public repos), read-only workflow tokens, Actions allowlist, secret scanning, Dependabot disabled, private vulnerability reporting (public repos)) — PR #77 (admin apply 2026-09-10; `--required-checks "zizmor,build"` `--allowed-actions "pnpm/*,codecov/*"`) |
There was a problem hiding this comment.
There is a discrepancy between the allowed actions list documented in SECURITY.md (which includes zizmorcore/* and SocketDev/) and the recorded --allowed-actions parameter in this file (which only lists pnpm/,codecov/). Update the recorded command to include all allowed patterns: --allowed-actions "zizmorcore/,SocketDev/,pnpm/,codecov/*"
There was a problem hiding this comment.
lockdown-repo.sh always allowlists GitHub-owned actions, verified creators, zizmorcore/*, and SocketDev/*. --allowed-actions is only the extra patterns passed on apply.
The recorded command is what the admin ran: --allowed-actions "pnpm/*,codecov/*". SECURITY.md describes the effective allowlist (defaults + those extras), which is why it also names zizmorcore/* and SocketDev/*. Combining everything into --allowed-actions would mis-document the apply flags.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 19 19
Branches 1 1
=========================================
Hits 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1d8150907
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - [ ] Phishing-resistant 2FA (passkeys / hardware keys) on the GitHub and npm accounts (manual) | ||
| - [ ] Recovery codes stored offline in a password manager (manual) | ||
| - [ ] `lockdown-repo.sh` applied by a repo admin (never committed to this repo); `--check` with `--required-checks` and `--allowed-actions` passes (PRs required on the default branch, merges blocked unless required status checks pass, tag ruleset, immutable releases, fork-PR approval (public repos), read-only workflow tokens, Actions allowlist, secret scanning, Dependabot disabled, private vulnerability reporting (public repos)) | ||
| - [x] `lockdown-repo.sh` applied by a repo admin (never committed to this repo); `--check` with `--required-checks` and `--allowed-actions` passes (PRs required on the default branch, merges blocked unless required status checks pass, tag ruleset, immutable releases, fork-PR approval (public repos), read-only workflow tokens, Actions allowlist, secret scanning, Dependabot disabled, private vulnerability reporting (public repos)) — PR #77 (admin apply 2026-09-10; `--required-checks "zizmor,build"` `--allowed-actions "pnpm/*,codecov/*"`) |
There was a problem hiding this comment.
The accompanying verification states that lockdown-repo.sh --check still returns 403 for the Actions-permission APIs, so there is no successful end-to-end check supporting this completed item. Marking it [x] and saying the check passes can cause future security reviews to treat settings that were never read back as verified; either run the complete check with an admin-capable token or document the unverified portions and leave the item incomplete.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed that this integration cannot treat --check as green: it 403s the Actions permission APIs (not an admin token).
What is verified:
- Admin apply output (all 9 settings ✓) with
--required-checks "zizmor,build"and--allowed-actions "pnpm/*,codecov/*" - Rulesets readable via API:
Pull requests required(code-owner review, required checkszizmorandbuild) andTags only by admins
I am not unchecking the apply. The catalog note now says --check was not re-run with an admin token from this agent. If you paste a successful admin --check with the same flags, I’ll add that to the line.
Co-authored-by: Jared Wray <me@jaredwray.com>
2 participants
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs / supply-chain hardening status.
Summary
Records that a repo admin applied
lockdown-repo.shonHyphen/react-sdk(defense-in-depth § 7). The script is not in this repo.Status update
DEFENSE_IN_DEPTH.md: lockdown-repo.sh → PR #77 (admin apply 2026-09-10, all 9 ✓; this token’s--check403s Actions permission APIs; rulesets confirmed via API)Verification
Pull requests required(required checkszizmor,build; code-owner review) andTags only by admins--checkfrom this token 403s Actions permission APIs (not admin) — documented on the catalog line, not claimed greenlockdown-repo.shis not committed hereStill unchecked (not this PR)
Reference
defense-in-depth-nodejs § 7