Repository navigation
Conversation
A night held by an open release pull request refused the slot and then said nothing on #80: it pushed nothing, so the record step exited, and the state kept only {number, title} of that pull request, so its ci-ok was never read. The refusal is unchanged. The collect step now reads the accepted release pull request's head and its ci-ok conclusion, with the names of the checks that failed; the pure open-pr reason names the head and the conclusion; and a held night posts one marker-guarded line on #80 keyed by number, head and conclusion. Fixes #1204.
HugoXK-bot
approved these changes
Nov 21, 2026
HugoXK-bot
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: PASS at 8f91df5
- The refusal is untouched:
scripts/lib/release-trigger.mjs:144still returnsno(...)(plan false, catchUp false, the boundary preserved) for an open release pull request, andopenPrReason(:69-88) only composes text — every otherdecideTriggerbranch and the whole drive/plan path are unchanged in the diff. - The collection uses the same predicate the state does:
selectedOpenPr(scripts/lib/release-state.mjs:90) isreleaseCandidates(...).candidate, the functionbuildStateitself consumes, so the head read at.github/workflows/daily-release.yml:134-151and the state can never disagree about which pull request is meant;--open-checks(:172) feedsopenPrCiOk/openPrFailedChecks(scripts/lib/release-state.mjs:156-157), which readmissingwhen no head or no collection exists (test/releaseState.test.ts:59-97). - The held line has its own path before the empty-push exit (
.github/workflows/daily-release.yml:519-597, exit at:555), keys its markerdaily-release:held:#<number>:<short head>:<conclusion>(:534), reads green and red differently, and shares the onegh issue comment 80call with the pushed shape;bash -non the extracted step is clean and the 25-minute timeout, the slot rule and the plan step are not touched. - Docs and changelog match the behaviour:
docs/deploy.md:480-495narrows "runs that pushed nothing never reach the write path" to the held case, while dry runs still write nothing (daily-release.yml:505keepsalways() && inputs.dry_run != true), andchangelog.d/1204.fixed.mdnames the defect. - Evidence: at this tip the three test files are 73/73; at base
044c7515with only the test hunks, exactly the three new tests fail (AssertionError,TypeError,AssertionError), so the Red section reproduces; the 32 latest checks at this sha are green (skipped where the path filter excludes them) exceptreview-gate, which is red only with "no conclusion at 8f91df5…"; the open head is read withoutfilter=, which is the API'slatestdefault (default 31 runs =filter=latest, whilefilter=allreturns 55 and includes superseded failures), so no stale names leak in.
Ran: npx tsx --test test/releaseTrigger.test.ts test/releaseState.test.ts test/dailyRelease.test.ts on a tree built from base044c7515+ this diff with all ten blobs hash-equal to the PR head — 73/73 pass; the same three files on base044c7515with only the test hunks applied — 69 pass, the three #1204 tests fail;bash -non the extractedComment on #80run block (exit 0);curlreads of the 32 latest check-runs at the sha and of9ee14f9's check-runs with and withoutfilter.
Not run: the workflow itself (it runs onschedule,pushtomainandworkflow_dispatch) — the held line is proven structurally plus the shell syntax check, not by a live held night;npm run checklocally (CIci-ok136934800647is green at this sha and my run covered the three affected files); no production deploy. Non-blocking note: the new open-head read sits on the collect step's critical path, so a 5xx there turns a green no-plan into a red run whose #80 step exits silently — the same failure class the collect step already had, not a new decision.
Written-by: HugoXK-bot
Owner
Author
|
Security: PASS at 8f91df5
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Fledge Platform Dev-1
Fixes #1204
What changed
A night held by an open release pull request used to be a green no-plan that said nothing anywhere a person reads. The refusal was right (
scripts/lib/release-trigger.mjs), the push step was gated on a plan (.github/workflows/daily-release.yml), and the #80 step exited on the empty push — while the collected state carried only{number, title}of that pull request, so itsci-okwas never read.#1200was red from02:05:32Zand #80 still only said "opened v0.4.5".The refusal stays exactly as it is: nothing here merges, closes, re-runs or pushes, and
open-prremains a no-plan. What changes is that the held night becomes visible:.github/workflows/daily-release.yml): the collect step picks the accepted release pull request with the same predicatebuildStateuses (the newselectedOpenPrexport inscripts/lib/release-state.mjs) and reads that head's check-runs besidemain's. The state now carriesopenPrCiOk(id, status, conclusion) andopenPrFailedChecks(names of concluded non-success checks); with no head or no collection it readsmissing, never a silent green. The CLI takes--open-checks.scripts/lib/release-trigger.mjs):openPrReasonnames the pull request, the short head and theci-okconclusion, plus the failing check names when it is red —open-pr: #1200 is the open release pull request at 9ee14f9, ci-ok failure (failing: ci-ok, test (24)). A caller that passes only the number keeps the old wording, so existing behaviour is unchanged..github/workflows/daily-release.yml): the held night gets its own path before the empty-push exit, posting one marker-guarded line keyed by#<number>:<short head>:<conclusion>. Green and red read differently, and the line repeats only when one of the three changes. Both shapes share the singlegh issue comment 80call.Red
At base
044c7515a6111560bf96cdd20e8c724535cefc0a, one new assertion per file, verbatim:test/releaseTrigger.test.ts(case 3b):AssertionError: the conclusion is part of the reason, so a red night is not silent— actual reasonopen-pr: #1200 is the open release pull request.test/releaseState.test.ts:TypeError: Cannot read properties of undefined (reading 'conclusion')— the state has noopenPrCiOk.test/dailyRelease.test.ts:AssertionError: the open-pr reason has a path of its own— the release: daily minor release with the 10+/5+ rule #80 step has no held path.Green at the tip: the three files together, 73/73.
Ran:
npm run checkat8f91df5ed16cc932f4891479c061d8e836c4ff1d— exit 0,# tests 3296 / # pass 3296 / # fail 0; lint 11 warnings (baseline); typecheck; build.node scripts/risk-gate.mjs --base origin/main—risk-tier: T3; basis: .github/workflows/daily-release.yml.bash -non the modified release: daily minor release with the 10+/5+ rule #80 step'srun:block — exit 0.node --testontest/releaseTrigger.test.ts,test/releaseState.test.ts,test/dailyRelease.test.ts— 73/73.Not run:
schedule,pushtomainandworkflow_dispatch, so the release: daily minor release with the 10+/5+ rule #80 line is proved by the structural test and the shell syntax check, not by a live run. No production deploy.#1200(merged as044c7515) is not depended on.Risk and rollback
T3:
.github/workflows/**andscripts/**. Revert this commit to restore the previous nightly; the slot rule, the planner, the trigger conditions and the refusal itself are untouched.Docs
docs/deploy.mdupdated: a held night now reports the pull request, its head and itsci-okon #80, and the "runs that pushed nothing never reach the write path" sentence is narrowed to the held-night case.Changelog
changelog.d/1204.fixed.md.