Skip to content

Paint 2.1: guide every view at the same strength, as upstream does (alpha.433) - #917

Open
kalebbroo wants to merge 1 commit into
mainfrom
fix/paint-view-guidance
Open

kalebbroo wants to merge 1 commit into
mainfrom
fix/paint-view-guidance

Conversation

@kalebbroo

Copy link
Copy Markdown
Contributor

Why

Upstream's Paint 2.1 pipeline scales each view's guidance by its azimuth (cam_mapping), but only when the caller passes camera_azims. Its texturing pipeline (textureGenPipeline → multiview_utils.forward_one) never does, so every view is guided at scale 1.

The engine applied the azimuth scale (ViewScale), which guided side and back views at twice the strength.

How it was checked

  1. I ran the official Python pipeline in Docker on upstream's own demo picture (assets/demo.png, the penguin).
  2. I captured exactly what it feeds the diffusion: the reference image, the 12 geometry maps and the starting noise. I replaced the VAE posterior sample with the mean, as the engine does.
  3. I fed those to the engine.

Results:

  • The geometry maps the engine renders itself match upstream's exactly (0.00–0.01/255 mean).
  • The reference matches to 0.03/255.
  • With this fix, the 12 generated views match upstream's to 0.4–0.7/255 mean (1.5 on the bottom view).

Tests

ThreeD paint tests: 45 passed, 11 skipped.

@kalebbroo

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T07:32:08.350638Z b9f2dc5 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b9f2dc51f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md
Comment on lines +8 to +11
- **Fixed: Hunyuan3D Paint 2.1 guides every view at the same strength, as upstream does.** The engine scaled each view's guidance by its
azimuth (side and back views at twice the strength). Upstream's pipeline applies that scale only when its caller passes `camera_azims`,
and its texturing pipeline never does. Checked by feeding upstream's own reference, geometry maps and starting noise (captured from a run
of the official Python pipeline) to the engine: the twelve generated views match upstream's to 0.4 to 1.5/255 mean.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove the bug-fix narrative from the changelog

This entry documents only a bug fix and its verification history, whereas docs/Agents/AGENTS.md explicitly excludes fixes and review follow-ups from changelog entries and requires eligible entries to be a single line. Remove this narrative; durable numerical evidence belongs in the parity ledger rather than the release changelog.

AGENTS.md reference: docs/Agents/AGENTS.md:L58-L60

Useful? React with 👍 / 👎.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant