Repository navigation
Conversation
…ring pipeline does (alpha.433)
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9f2dc51f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - **Fixed: Hunyuan3D Paint 2.1 guides every view at the same strength, as upstream does.** The engine scaled each view's guidance by its | ||
| azimuth (side and back views at twice the strength). Upstream's pipeline applies that scale only when its caller passes `camera_azims`, | ||
| and its texturing pipeline never does. Checked by feeding upstream's own reference, geometry maps and starting noise (captured from a run | ||
| of the official Python pipeline) to the engine: the twelve generated views match upstream's to 0.4 to 1.5/255 mean. |
There was a problem hiding this comment.
Remove the bug-fix narrative from the changelog
This entry documents only a bug fix and its verification history, whereas docs/Agents/AGENTS.md explicitly excludes fixes and review follow-ups from changelog entries and requires eligible entries to be a single line. Remove this narrative; durable numerical evidence belongs in the parity ledger rather than the release changelog.
AGENTS.md reference: docs/Agents/AGENTS.md:L58-L60
Useful? React with 👍 / 👎.
Why
Upstream's Paint 2.1 pipeline scales each view's guidance by its azimuth (
cam_mapping), but only when the caller passescamera_azims. Its texturing pipeline (textureGenPipeline→multiview_utils.forward_one) never does, so every view is guided at scale 1.The engine applied the azimuth scale (
ViewScale), which guided side and back views at twice the strength.How it was checked
assets/demo.png, the penguin).Results:
Tests
ThreeD paint tests: 45 passed, 11 skipped.