Repository navigation
Return the collect result from the egg and feather pickups - #645
Merged
Merged
Conversation
JeodC
force-pushed
the
fix-collectible-return
branch
from
October 23, 2026 15:31
39d10f2 to
6bbe413
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes infinite eggs and feathers after a Yum-Yum drops them. The egg and feather collect functions never returned
chCollectible_collectItem's result, so in release builds a dropped pickup wasn't despawned and was collected again every frame.Consumable retention now spawns the Yum-Yum's drops too. Before, a drop could inherit a stale hut-drop identity from
actor->local, or be cancelled by the collected-position check after the clam had already taken the eggs.Build Artifacts