update most tests, don't use stdout in ipsframework, fix a few bugs - #257
Open
Lance-Drane wants to merge 3 commits into
Open
update most tests, don't use stdout in ipsframework, fix a few bugs#257Lance-Drane wants to merge 3 commits into
Lance-Drane wants to merge 3 commits into
Conversation
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
1) don't use hand-rolled env gated file logger --- 2) remove Pyro code --- 3) use shutil.which instead of handrolled 'which' --- 4) simplify EventManager by using lazy-set attributes instead of objcache dict Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mostly fixes tests, except for a few:
test_trace.pyis timing-dependent andtest_basic_serialfails under pytest's forked multiprocessing (loses venv resolution). Will address these laterThis also removes several redundant
printstatements, and swaps any remaining STDOUT outputs to STDERR EXCEPT for thelogfileproperty in thelaunchfunction. This is useful for general "force a flush after call, whether or not STDOUT is a TTY" purposes, and will be useful in the future for setting up E2E tests.Renames
Bugs fixed
The AI caught a few bugs here:
task_manager.py: mpirun --display ALLOCATION,MAP-DEVEL,BINDINGS was wrongly added for plain single-node mpirun (should only apply to DVM/prun)services.py- submit_dask_tasks() computed return len(self.futures) after resetting self.futures = [], always returning 0; and get_dask_finished_tasks_status() discarded blocking-mode results and got mis-routed after _shutdown_dask() reset dask_pool=False — both fixed by caching results in self.dask_resultsservices.py- _process_dask_event crashed on the return_value key Dask injects into callable-task events; now stripped like the existing worker keyQuick code minimizing
Only made changes here which didn't change the APIs in the
servicesclassipsutil.which()implementation withshutil.which()(could probably remove this entirely if we don't care about the unique API)EventManagerimplementationdebug.pywith the stdlib logger, keeping theIPSES_DEBUGenvironment variable for now. We may want to remove this file eventually.The AI also recommended nuking the RUS section (especially the vendored fork of the
configobjdependency when we are including this in our own dependencies) and to consider shrinkingcca_es_spec.py.