Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| this.legacyFabric = new LegacyFabricVersionList(this); | ||
| this.legacyFabricApi = new LegacyFabricAPIVersionList(this); | ||
| this.legacyFabricApi = new ModrinthComponentVersionList(this, GameComponentType.LEGACY_FABRIC_API, "9CJED7xi"); | ||
| ; |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.coding.EmptyStatementCheck]
Empty statement.
|
|
||
| private static String normalizeVersion(String version) { | ||
|
|
||
| @Override |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck]
'METHOD_DEF' has more than 1 empty lines before.
| public JsonObject getLauncherMeta() { | ||
| return launcherMeta; | ||
| } | ||
| protected String getMavenRepositoryByGroup(String maven) { |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck]
'METHOD_DEF' has more than 1 empty lines before.
| this.quiltApi = new ModrinthComponentVersionList(this, GameComponentType.QUILT_API, "qvIfYCYJ"); | ||
| this.legacyFabric = new LegacyFabricVersionList(this); | ||
| this.legacyFabricApi = new LegacyFabricAPIVersionList(this); | ||
| this.legacyFabricApi = new ModrinthComponentVersionList(this, GameComponentType.LEGACY_FABRIC_API, "9CJED7xi");; |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.coding.EmptyStatementCheck]
Empty statement.
| this.legacyFabric = new LegacyFabricVersionList(this); | ||
| this.legacyFabricApi = new LegacyFabricAPIVersionList(this); | ||
| this.legacyFabricApi = new ModrinthComponentVersionList(this, GameComponentType.LEGACY_FABRIC_API, "9CJED7xi"); | ||
| ; |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.coding.EmptyStatementCheck]
Empty statement.
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/TaskListPane.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DownloadPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/ModListPage.java # HMCL/src/main/resources/assets/lang/I18N_uk.properties # HMCL/src/main/resources/assets/lang/I18N_zh_Hans.properties
| import org.jackhuang.hmcl.addon.mod.ModLoaderType; | ||
| import org.jackhuang.hmcl.addon.RemoteAddon; | ||
| import org.jackhuang.hmcl.addon.RemoteAddonRepository; | ||
| import org.jackhuang.hmcl.addon.mod.ModLoaderType; |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.imports.RedundantImportCheck]
Duplicate import to line 35 - org.jackhuang.hmcl.addon.mod.ModLoaderType.
| import org.jackhuang.hmcl.addon.RemoteAddon; | ||
| import org.jackhuang.hmcl.addon.RemoteAddonRepository; | ||
| import org.jackhuang.hmcl.addon.mod.ModLoaderType; | ||
| import org.jackhuang.hmcl.download.DownloadProvider; |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.imports.RedundantImportCheck]
Duplicate import to line 33 - org.jackhuang.hmcl.download.DownloadProvider.
1 participant
目前很多代码被复制了 Fabric、Legacy Fabric、Quilt 三份，改动的时候比较不方便且如果要添加新加载器（如 Ornithe 还得再复制一份）