Repository navigation
Raise KeyError for missing keys in RepositoryEmpty - #192
Open
hulei22103-gif wants to merge 2 commits into
Open
hulei22103-gif wants to merge 2 commits into
hulei22103-gif wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RepositoryEmpty returns None for every direct lookup even though it reports every key as absent. This differs from the other repositories' missing-key behavior and can hide a missing configuration value when accessing the repository directly.
Raise KeyError(key) instead. Config still checks membership before looking up repository values, so environment lookup, explicit defaults and UndefinedValueError remain unchanged.
Fixes #175.
Tests cover missing keys and the exception's key argument, plus Config's missing-value error, None default, casted default, and empty/nonempty environment values.
Validation on Windows, Python 3.12.5:
python -m pytest -q— 74 passed.git diff --check— passed.Python 2.7 and the upstream CI matrix were not run locally.
AI disclosure: the fix and regression tests were prepared and verified with Codex assistance.