feat: render --print output as styled markdown with --markdown - #292
Merged
Conversation
Add a --markdown root flag that renders the --print text-mode response through the existing markdown renderer (teal headers, bold, inline code, fenced code blocks, lists). Rendering only happens when color is enabled (ShouldColor), so piped/NO_COLOR output stays raw and machine-parseable. When --markdown is set, the response is buffered and rendered at the end instead of streamed raw, since partial markdown cannot be styled. Default streaming behavior is unchanged; json/stream-json output is untouched. Extract renderPrintResponse for testability; unit-test the raw/render and color gating. Update the root-help golden file for the new flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--markdownroot flag that renders--printtext-mode output through the existing markdown renderer (teal headers, bold, inline code, fenced code blocks, lists) instead of dumping raw**bold**/# headertext.Rendering is gated on
ShouldColor()(TTY orFORCE_COLOR, notNO_COLOR/--quiet), so piped/scripted output stays raw and machine-parseable. When--markdownis set the response is buffered and rendered at the end (partial markdown cannot be styled); default streaming behavior is unchanged, andjson/stream-jsonoutput is untouched.Verification
go build ./...,go vet ./cmd/,gofumpt -lclean.go test ./...exit 0 (incl. regenerated root-help golden file).TestRenderPrintResponsecovers raw-when-color-off, raw-when-markdown-off, and styled-ANSI-when-both.graycode --helpshows--markdown).