feat: ANSI-safe aligned table rendering - #290
Merged
Merged
Conversation
Add theme.PrintTable, which computes column widths on ANSI-stripped visible width so colored cells never break alignment (text/tabwriter counts escape bytes as width). Migrate the plain list tables (trust list, search, agent list, plugin status, plugin events, plugin marketplace list) to it, giving them a consistent muted colored header and fixing the latent misalignment in plugin status's already-colored header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
theme.PrintTable, a table renderer that computes column widths on ANSI-stripped visible width.text/tabwritercounts ANSI escape bytes as cell width, so any colored cell (header or value) shifts alignment —plugin status's existing colored header already misaligned.Migrates six plain list tables to it (
trust list,search,agent list,plugin status,plugin events,plugin marketplace list), giving them a consistent muted header that stays aligned under color.Verification
go build ./...,go vet ./cmd/ ./internal/theme/,gofumpt -lclean.go test ./...exit 0.TestPrintTable*unit tests cover alignment, color-not-breaking-alignment, short rows, empty header.env -u NO_COLOR FORCE_COLOR=1 graycode trust listshows muted colored header with correctly aligned columns.