Repository navigation
feat(#3815): Added the size property to Date Picker - #4355
Merged
Merged
Conversation
|
Preview removedAll preview folders cleaned from gh-pages branch. |
twjeffery
reviewed
Oct 15, 2026
twjeffery
left a comment
twjeffery
left a comment
Collaborator
There was a problem hiding this comment.
@ArakTaiRoth Looks good. One thing to change, the space between the inputs should be --goa-space-l for the default size and --goa-space-m for compact.
ArakTaiRoth
force-pushed
the
dustin/3815
branch
from
October 16, 2026 17:39
c89747a to
7be3571
Compare
twjeffery
self-requested a review
October 16, 2026 19:15
twjeffery
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (the change)
There was a
sizeproperty supported by the Date Picker component, but it didn't exist for the Angular and React wrappers, and so was unusable by the vast majority of our users.After (the change)
sizenow added to Date Picker Angular and React wrappers. Examples have been created in documentation, and on the PR docs page for Date Picker.Make sure that you've checked the boxes below before you submit the PR
Steps needed to test
Check out the documentation page for Date Picker, verify the properties table for both Angular and React, and check the new
Sizesexample on the main documentation page. Also can check the docs PR page for Date Picker for both Angular and React.