fix(ci): grant contents write to the release job - #237
Merged
Conversation
ncipollo/release-action creates the tag and release with GITHUB_TOKEN, which needs contents write. The least-privilege change left it at read, and this workflow uploads to PyPI before that step, so a failure would leave a package without a tag. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Release workflow publishes to PyPI first and then creates the tag and GitHub release with
GITHUB_TOKEN, but the least-privilege change pinned the workflow tocontents: read. The same setup just failed in stream-chat-go withError 403: Resource not accessible by integration. Here it would fail after the PyPI upload, leaving a published package with no tag.Solution
contents: writeon the Release workflow, the minimumncipollo/release-actionneeds to push a tag and create a release.pull-requestsstays read-only.How to verify
Create release PR.release-*PR into master; theCreate release on GitHubstep passes and the tag appears under Releases.🤖 Generated with Claude Code