feat: add skip_truncate to channel delete - #236
Merged
Conversation
Soft deleting a channel truncates it, so a channel recreated with the same id comes back empty. Channel.delete takes skip_truncate and sends it as a query param when set. Client.delete_channels already forwards options, so the batch endpoint needs no change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The async path had no test for skip_truncate being omitted, so sending it as false would have passed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
yaziine
reviewed
Sep 10, 2026
yaziine
previously approved these changes
Sep 10, 2026
yaziine
approved these changes
Sep 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
CHA-5241
Problem
Soft deleting a channel also truncates it, so a channel recreated with the same id comes back empty and replies quoting older messages fail. The API gained a
skip_truncateoption that keeps the history, andChannel.deletecannot send it.Solution
Channel.deletetakesskip_truncate: bool = Falsein the sync and async clients, and adds the query param only when it is set, so existing calls send the same request as before.Client.delete_channelsalready forwards**optionsinto the request body, so the batch endpoint needed no code change, only a docs example.The server owns the rules:
skip_truncateis rejected together with a hard delete, and only distinct channels are eligible.How to verify
pytest stream_chat/tests/test_channel_delete.pypasses. The three tests assert the param is absent by default and present when set, sync and async.make lintpasses (black, flake8, mypy).🤖 Generated with Claude Code