Repository navigation
fix(eden): drop autoinstall from the template's kernel line; correct the password record; finish #1443 - #1534
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The runbook incorrectly describes a normal reapply as a clone failure and directs users toward destructive replacement instead of documenting the expected no-op behavior.
1 open issue
What changed in this PR
This PR removes the installer’s autoinstall flag from future Ubuntu templates and updates the operational records and runbooks to reflect eden’s completed OpenTofu migration.
Changes:
- Clear
autoinstallbefore regenerating GRUB and fail the template build if it remains. - Correct the admin-password record and document the template fix and migration completion.
- Remove completed #1443 tasks and replace the one-time import instructions with a rebuild procedure.
| File | Description |
|---|---|
packer/ubuntu/prune.sh |
Remove and check for the leftover autoinstall flag. |
docs/runbooks/deploy-merged-changes.md |
Remove completed migration steps. |
docs/runbooks/build-the-lab-templates.md |
Document the new template cleanup. |
docs/runbooks/build-the-bloodhound-guest.md |
Replace import instructions with an explicit rebuild procedure. |
docs/roadmap.md |
Remove the completed #1443 entry. |
docs/changelog.md |
Record migration completion, the password correction, and the template fix. |
Review effort: Balanced
…the password record; finish #1443 A live re-check of eden found three things the records got wrong or left: - The admin password had not been changed. auth_secrets and the audit log showed no change; it was changed and checked in the database on 2026-11-16 08:43 UTC. A changelog correction names the entry it corrects. - Subiquity copied the boot command's `autoinstall` into GRUB_CMDLINE_LINUX_DEFAULT on every clone. prune.sh clears it and fails the build if it is left; eden was cleared by hand. - eden is in tofu's state: an untargeted plan said No changes. The roadmap entry and the one-time deploy step leave, and the BloodHound runbook rebuilds with -replace. Closes #1443. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gerrrt
force-pushed
the
fix/eden-recheck
branch
from
November 16, 2026 09:21
b06c3d5 to
2393d4e
Compare
Gerrrt
disabled auto-merge
November 16, 2026 09:35
5 of 6 tasks
Gerrrt
added a commit
that referenced
this pull request
Nov 16, 2026
Refs #1534 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
packer/ubuntu/prune.shclears the installer'sautoinstallfromGRUB_CMDLINE_LINUX_DEFAULTbefore regenerating GRUB, and fails the build if it is still ingrub.cfg.build-the-lab-templates.md§4 says so.docs/changelog.mdgets three entries:eden's admin password changed, and X11 forwarding turned off by hand: the password was not changed until 08:43 UTC today;edenin tofu's state, which completes Declare eden and ragnarok in tofu (ADR-0076's scope), and settle how ragnarok's isolation proof survives it #1443.deploy-merged-changes.md's one-time steps.build-the-bloodhound-guest.md§1 now rebuildsedenwith-replace, replacing the import that has already been done.On
eden, by hand:GRUB_CMDLINE_LINUX_DEFAULTwas cleared andupdate-grubrun. It takes effect at the next reboot.Why
A live re-check of
eden, asked for after the audit was called complete, found:auth_secrets, the admin row'supdated_atequalled itscreated_at(2026-11-13 03:28). BloodHound's audit log had no password action and no activity after 2026-11-15 05:25. It has now been changed, and the database showsUpdateAuthSecretsucceeding at 08:43:33, with expiry 2027-02-14.autoinstallon its kernel line.edenhand-built, but the untargetedtofu planonphoenixtoday said No changes, with 141 and 130 both refreshed.ragnarok's half was done under feat(tofu): build ragnarok on gandalf, and finish and prove it with a script #1464.Closes #1443.
Blast radius
Template 901's next build. Clones made before it keep
autoinstalluntil it is cleared by hand. It does nothing on an installed system.eden: a kernel command-line change at its next boot.No running service changes.
No change to network segmentation or firewall rules
No new port published to a VLAN that could not already reach the service
No credential added outside
secrets/*.sops.yamlVerification
On
eden:/etc/default/grubnow hasGRUB_CMDLINE_LINUX_DEFAULT="". Afterupdate-grub,grep -c autoinstall /boot/grub/grub.cfg= 0, and the kernel line reads… ro.In BloodHound's Postgres:
auth_secretsupdated_at2026-11-16 08:43:33,expires_at2027-02-14, and the audit log showsUpdateAuthSecretsuccess.On
phoenix:tofu -chdir=tofu planprinted "No changes. Your infrastructure matches the configuration."sh -n packer/ubuntu/prune.shpasses../scripts/lint.shpasses, shellcheck included; yamllint, ruff (×2) and ansible-lint were skipped because they are not installed oneden.python3 scripts/check_docs.pyis OK.Not built: template 901 needs another Ubuntu build to carry the change.
make validatewas not run, per CLAUDE.md oneden.make validatepassesDeployed to the lab and confirmed working
Docs updated (
docs/, service README, ordocs/roadmap.md)🤖 Generated with Claude Code