Skip to content

fix(eden): drop autoinstall from the template's kernel line; correct the password record; finish #1443 - #1534

Merged
Gerrrt merged 2 commits into
mainfrom
fix/eden-recheck
Nov 16, 2026
Merged

Gerrrt merged 2 commits into
mainfrom
fix/eden-recheck

Conversation

@Gerrrt

@Gerrrt Gerrrt commented Nov 16, 2026

Copy link
Copy Markdown
Owner

What changed

On eden, by hand: GRUB_CMDLINE_LINUX_DEFAULT was cleared and update-grub run. It takes effect at the next reboot.

Why

A live re-check of eden, asked for after the audit was called complete, found:

  • The admin password had never changed. In auth_secrets, the admin row's updated_at equalled its created_at (2026-11-13 03:28). BloodHound's audit log had no password action and no activity after 2026-11-15 05:25. It has now been changed, and the database shows UpdateAuthSecret succeeding at 08:43:33, with expiry 2027-02-14.
  • Every clone of 901 boots with autoinstall on its kernel line.
  • The roadmap still called eden hand-built, but the untargeted tofu plan on phoenix today said No changes, with 141 and 130 both refreshed. ragnarok's half was done under feat(tofu): build ragnarok on gandalf, and finish and prove it with a script #1464.

Closes #1443.

Blast radius

  • Template 901's next build. Clones made before it keep autoinstall until it is cleared by hand. It does nothing on an installed system.

  • eden: a kernel command-line change at its next boot.

  • No running service changes.

  • No change to network segmentation or firewall rules

  • No new port published to a VLAN that could not already reach the service

  • No credential added outside secrets/*.sops.yaml

Verification

  • On eden: /etc/default/grub now has GRUB_CMDLINE_LINUX_DEFAULT="". After update-grub, grep -c autoinstall /boot/grub/grub.cfg = 0, and the kernel line reads … ro.

  • In BloodHound's Postgres: auth_secrets updated_at 2026-11-16 08:43:33, expires_at 2027-02-14, and the audit log shows UpdateAuthSecret success.

  • On phoenix: tofu -chdir=tofu plan printed "No changes. Your infrastructure matches the configuration."

  • sh -n packer/ubuntu/prune.sh passes. ./scripts/lint.sh passes, shellcheck included; yamllint, ruff (×2) and ansible-lint were skipped because they are not installed on eden. python3 scripts/check_docs.py is OK.

  • Not built: template 901 needs another Ubuntu build to carry the change. make validate was not run, per CLAUDE.md on eden.

  • make validate passes

  • Deployed to the lab and confirmed working

  • Docs updated (docs/, service README, or docs/roadmap.md)

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings November 16, 2026 09:01
@Gerrrt
Gerrrt enabled auto-merge (squash) November 16, 2026 09:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The runbook incorrectly describes a normal reapply as a clone failure and directs users toward destructive replacement instead of documenting the expected no-op behavior.

1 open issue
What changed in this PR

This PR removes the installer’s autoinstall flag from future Ubuntu templates and updates the operational records and runbooks to reflect eden’s completed OpenTofu migration.

Changes:

  • Clear autoinstall before regenerating GRUB and fail the template build if it remains.
  • Correct the admin-password record and document the template fix and migration completion.
  • Remove completed #1443 tasks and replace the one-time import instructions with a rebuild procedure.
File Description
packer/​ubuntu/​prune.sh Remove and check for the leftover autoinstall flag.
docs/​runbooks/​deploy-merged-changes.md Remove completed migration steps.
docs/​runbooks/​build-the-lab-templates.md Document the new template cleanup.
docs/​runbooks/​build-the-bloodhound-guest.md Replace import instructions with an explicit rebuild procedure.
docs/​roadmap.md Remove the completed #1443 entry.
docs/​changelog.md Record migration completion, the password correction, and the template fix.

Review effort: Balanced

…the password record; finish #1443

A live re-check of eden found three things the records got wrong or left:

- The admin password had not been changed. auth_secrets and the audit log
  showed no change; it was changed and checked in the database on
  2026-11-16 08:43 UTC. A changelog correction names the entry it corrects.
- Subiquity copied the boot command's `autoinstall` into
  GRUB_CMDLINE_LINUX_DEFAULT on every clone. prune.sh clears it and fails
  the build if it is left; eden was cleared by hand.
- eden is in tofu's state: an untargeted plan said No changes. The roadmap
  entry and the one-time deploy step leave, and the BloodHound runbook
  rebuilds with -replace.

Closes #1443.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…berate rebuild

Addresses review on #1534.

Refs #1443

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Gerrrt
Gerrrt disabled auto-merge November 16, 2026 09:35
@Gerrrt
Gerrrt merged commit 616706f into main Nov 16, 2026
8 checks passed
@Gerrrt
Gerrrt deleted the fix/eden-recheck branch November 16, 2026 09:35
Gerrrt added a commit that referenced this pull request Nov 16, 2026
Refs #1534

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Declare eden and ragnarok in tofu (ADR-0076's scope), and settle how ragnarok's isolation proof survives it

2 participants