fix(team): Prevent null dereference in TeamFactory::createTeam - #592
Open
sentry[bot] wants to merge 1 commit into
Open
fix(team): Prevent null dereference in TeamFactory::createTeam#592sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses CLIENT-38X by adding a null check in
TeamFactory::createTeambefore callingt->setActive().Previously,
createInactiveTeam(name)could returnnullptrif the specified team prototype did not exist.TeamFactory::createTeamwould then unconditionally attempt to callsetActive()on this null pointer, leading to a fatalEXCEPTION_ACCESS_VIOLATION_READcrash.The fix introduces a check: if
createInactiveTeamreturnsnullptr,createTeamnow safely returnsnullptras well. Callers ofcreateTeamare already designed to handle a null return value, ensuring robust behavior.Changes were applied to:
Generals/Code/GameEngine/Source/Common/RTS/Team.cppGeneralsMD/Code/GameEngine/Source/Common/RTS/Team.cppFixes CLIENT-38X
This PR was automatically generated by Sentry. You can adjust this setting at any time.