Dispose random view selectors - #217
Merged
Merged
Conversation
zayenz
force-pushed
the
feature/int-var-rnd-dispose
branch
from
July 8, 2026 06:35
c1f896b to
3babcc8
Compare
6 tasks
zayenz
force-pushed
the
feature/int-var-rnd-dispose
branch
2 times, most recently
from
July 11, 2026 05:22
a3f4872 to
c8e7973
Compare
zayenz
marked this pull request as ready for review
July 11, 2026 06:13
zayenz
force-pushed
the
feature/int-var-rnd-dispose
branch
from
July 11, 2026 07:33
c8e7973 to
67a8d10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notice()anddispose()to the random view selector so itsRndhandle is destroyed when branchers are discarded.Fixes #62.
Validation
cmake -S . -B /tmp/gecode-int-var-rnd-dispose-build -DCMAKE_BUILD_TYPE=Debug -DGECODE_ENABLE_EXAMPLES=OFF -DGECODE_ENABLE_GIST=OFF -DGECODE_ENABLE_QT=OFFcmake --build /tmp/gecode-int-var-rnd-dispose-build --target gecode-test -j 8/tmp/gecode-int-var-rnd-dispose-build/bin/gecode-test -iter 1 -test ^Int::Branch::Dense::3/tmp/gecode-int-var-rnd-dispose-build/bin/gecode-test -iter 1 -test ^Int::Branch::Sparse::3git diff --checkNote: I also started the full
Int::Branchfamily, observed passing progress, and stopped it because it was too broad for this resource-management fix.