fix(blocks): honor mob-spawn config on Waterstone/Lavastone/Sand - #104
Merged
PLASMAchicken merged 2 commits intoSep 9, 2026
Merged
Conversation
BlockMultiLayer implements ICarvable, so its item tooltip shows "Mobs cannot Spawn on this Block" whenever canMobsSpawnOnTheChiselBlocks is disabled, but unlike BlockCarvable it never overrode canCreatureSpawn, so the setting was never actually enforced on Waterstone (and Lavastone, which happened to mask the bug via its high light level blocking hostile spawns). Fixes GTNewHorizons/GT-New-Horizons-Modpack#26703
PLASMAchicken
added
the
Bug Fix
Same root cause as Waterstone/Lavastone: BlockCarvableSand is a full opaque block (Material.sand) implementing ICarvable, so it shows the "Mobs cannot Spawn on this Block" tooltip whenever canMobsSpawnOnTheChiselBlocks is disabled, but never overrode canCreatureSpawn to actually enforce it. Verified against the decompiled Forge source in build/rfg: unlike the carvable Glass/Ice/PackedIce/Beacon blocks (which never reach canCreatureSpawn at all because they fail the earlier solid-top-surface check via a translucent material or renderAsNormalBlock=false), Sand uses an opaque material with no such override, so it passes that check and defaults canCreatureSpawn to true.
PLASMAchicken
changed the title
seventh-june
approved these changes
Sep 8, 2026
seventh-june
left a comment
seventh-june
left a comment
There was a problem hiding this comment.
love when there's just a config option pointing itself to literally nowhere
Member
|
Ee3 deps seems to be broken. I hope done day we can yeet all non gtnh pack mods as deps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlockWaterstoneextendsBlockMultiLayer, which implementsICarvable. The item tooltip logic inItemCarvable.addInformationshows "Mobs cannot Spawn on this Block" for anyICarvableblock whenever thecanMobsSpawnOnTheChiselBlocksconfig is disabled - but onlyBlockCarvableactually overrodecanCreatureSpawnto enforce that setting.BlockMultiLayernever did, so Waterstone showed the tooltip without the behavior backing it up.Lavastone (also
BlockMultiLayer) has the identical underlying bug, but it's been masked because its light level of 15 incidentally blocks hostile mob spawns.This adds the same
canCreatureSpawnoverride toBlockMultiLayerthatBlockCarvablealready has, so it consultsConfigurations.canMobsSpawnOnTheChiselBlocks— fixing both Waterstone and Lavastone.Same story for chiseled Sand (
BlockCarvableSand) - full opaque block, no override, so added it there too. Chiseled Glass/Ice/PackedIce/Beacon show the same tooltip but don't have this bug: they never reachcanCreatureSpawnat all since their material/render setup already fails vanilla's earlier "solid top surface" check.Fixes GTNewHorizons/GT-New-Horizons-Modpack#26703
Test plan
canMobsSpawnOnTheChiselBlocks=falseThis Repo misses the template btw