Repository navigation
feat(cli): add upload result identity metadata - #62
Merged
Merged
Conversation
Include success, projectId, channelId and the actual upload serverUrl in bundle-drop-result.json. Retain null IDs for older backends and failed uploads, and preserve existing result fields.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
GFean
added a commit
that referenced
this pull request
Nov 9, 2026
🤖 I have created a release *beep* *boop* --- ## [0.12.0](v0.11.0...v0.12.0) (2026-11-09) ### Features * **cli:** add upload result identity metadata ([#62](#62)) ([2afb933](2afb933)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful CLI uploads now include
success,projectId,channelId, and the actual uploadserverUrlinbundle-drop-result.json, alongside the existing result fields. Older backends retain null IDs; failed uploads report null IDs and their upload endpoint. The server URL comes from the endpoint used by the CLI, rather than response metadata.Adds coverage for successful/failed uploads, older backend responses, staging/production endpoints, and untrusted response server URLs. Only the CLI source and tests change; no README, dependency, version, native runtime, or fingerprint baseline changes.
Validation:
yarn verify:quickon Node 22.13.0 passed: 105 suites / 2,237 tests, with 1 suite / 5 existing skips; coverage gate, frozen fingerprint contract, 12 Expo plugin checks, and 362-file package inspection passed. GitHub CI will run the platform and packaged CLI matrix. Dependabot #61 remains separate because its semver update requires review against the frozen fingerprint contract.