Repository navigation
Vorschaubilder über rex_socket laden (Proxy), filemtime-Warnung beheben - #512
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Die YouTube-/Vimeo-Vorschaubilder für Inline-Consent (Media-Manager-Effekt
external_thumbnail) undThumbnailCachehaben externe URLs mit eigenem cURL plusfile_get_contents-Fallback geladen – zwei Implementierungen an zwei Stellen, ohne den Proxy aus der REDAXO-Konfiguration.Utility::httpGet($url, $timeout, $headers, $logErrors)auf Basis vonrex_socket: nutztsocket_proxy, folgt bis zu 5 Weiterleitungen, prüft SSL, gibt bei Status 200 den Inhalt zurück, sonstnull.ThumbnailCachenutzen sie; User-Agent, Accept-Header und Timeouts bleiben wie bisher. cURL-Code und Fallback entfallen (−147 / +59 Zeilen).consent_manager: HTTP 404 for https://…) statt nur „External thumbnail HTTP error“.ThumbnailCache::cacheYouTubeThumbnail()/cacheVimeoThumbnail():filemtime()wurde vor der Existenzprüfung aufgerufen – PHP-Warnung bei jedem noch nicht gecachten Video.Getestet (REDAXO 5.21.6), vorher/nachher identisch:
ThumbnailCache::cacheYouTubeThumbnail()/cacheVimeoThumbnail()laden und cachen, ohne Warnung.🤖 Generated with Claude Code