Repository navigation
Insert, move and resize images in a PDF - #88
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Edit mode lets readers replace an existing image. Adding a photo or diagram to a page required another PDF editor.
Change
Choose Insert image or paste a PNG or JPEG in Edit mode. Drag the image into place and resize it from any corner. Choose Place image to keep editing or Save copy to save immediately. The saved PDF preserves PNG transparency and camera JPEG orientation.
Issue or approval
Closes #48. Maintainer approval.
How I checked it
On macOS, TypeScript, the production build, all 259 unit tests, and the full hidden Electron smoke suite passed. The new cross-platform smoke test edits text, inserts a JPEG, and pastes a transparent PNG on a rotated, cropped page. It independently renders the saved PDF, checks both images against their on-screen positions and sizes, verifies transparency and orientation, and reopens the copy in Folio.
Before
After
Implemented and tested by GPT-6 in OpenAI Codex.