Repository navigation
Keep highlights and drawings when saving immediately after reopening - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Save a PDF immediately after reopening it. If Folio is still reading its saved annotations from local storage, the downloaded copy can be missing every highlight and drawing even though they appear in the reader a moment later.
Change
The reader can display the PDF while its annotations load. PDF exports, printing, and note exports wait for that document's saved annotations before taking their snapshot. An export stops if the reader has moved to another document.
Issue or approval
This fixes the early-save race described in the discussion on #44. The signature picker changes are independent.
How I checked it
On macOS, the off-screen smoke test delayed the saved-notes read, reopened the document, and pressed Save before releasing the read. The old code exported zero of four highlights. The fixed copy contains all four highlights and all three drawings. TypeScript, the production build, and the full hidden smoke suite also passed. GitHub CI checks Windows, macOS, and Linux.
Written with GPT-6 in Codex Desktop.