Add missing changeset and update node version to 22 by ancheetah · Pull Request #597 · ForgeRock/forgerock-javascript-sdk

ancheetah · 2026-10-14T15:19:51Z

JIRA Ticket

Description

Adds missing changeset for token vault vulnerability fix
Updates node version to 24 for provenance and trusted publishing: https://docs.npmjs.com/trusted-publishers

changeset-bot · 2026-10-14T15:19:58Z

🦋 Changeset detected

Latest commit: f959b98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@forgerock/token-vault	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nx-cloud · 2026-10-14T15:20:32Z

View your CI Pipeline Execution ↗ for commit f959b98

Command	Status	Duration	Result
`nx affected -t build lint test docs e2e-ci`	✅ Succeeded	44s	View ↗
`nx-cloud record -- nx format:check --verbose`	✅ Succeeded	3s	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-10-20 20:36:39 UTC

nx-cloud

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud is proposing a fix for your failed CI:

We fixed the failing javascript-sdk:test run by running device.store.test.ts in the node vitest environment instead of jsdom. This avoids the jsdom/undici AbortSignal mismatch that made the RTK Query requests fail and return no data. With these changes, all 158 tests pass locally and lint passes.

Tip

✅ We verified this fix by re-running javascript-sdk:test.

diff --git a/packages/javascript-sdk/src/device-client/device.store.test.ts b/packages/javascript-sdk/src/device-client/device.store.test.ts
index 897e45b..c60d2a2 100644
--- a/packages/javascript-sdk/src/device-client/device.store.test.ts
+++ b/packages/javascript-sdk/src/device-client/device.store.test.ts
@@ -1,3 +1,4 @@
+// @vitest-environment node
 /*
  * @forgerock/javascript-sdk
  *
diff --git a/packages/javascript-sdk/vitest.setup.ts b/packages/javascript-sdk/vitest.setup.ts
index 644736e..6677b41 100644
--- a/packages/javascript-sdk/vitest.setup.ts
+++ b/packages/javascript-sdk/vitest.setup.ts
@@ -1 +1,4 @@
-import 'vitest-canvas-mock';
+// Some suites opt into the node environment (no `window`), e.g. when using Node's native fetch
+if (typeof window !== 'undefined') {
+  await import('vitest-canvas-mock');
+}

Or Apply changes locally with:

npx nx-cloud apply-locally SS5U-j5aM

Apply fix locally with your editor ↗ View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

SteinGabriel

CONTRIBUTING.md:16 still says "Node 20" instead of 22. Other than that, it looks ready to merge.

pkg-pr-new · 2026-10-14T21:52:10Z

Open in StackBlitz

pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/ping-protect@597

pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/javascript-sdk@597

pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/token-vault@597

commit: f959b98

codecov-commenter · 2026-10-14T21:52:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.58%. Comparing base (87775ec) to head (f959b98).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #597      +/-   ##
===========================================
- Coverage    56.72%   56.58%   -0.15%     
===========================================
  Files          105      105              
  Lines        28457    28534      +77     
  Branches      1644     1644              
===========================================
+ Hits         16143    16145       +2     
- Misses       12314    12389      +75

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cerebrl

This PR looks fine, but I have a question about the Changeset not really describing what's in this PR.

cerebrl · 2026-10-14T23:23:36Z

+'@forgerock/token-vault': patch
+---
+
+Compose AM request URLs from config to prevent attacker-supplied request URLs


This Changeset is a little confusing for me. Did we not include a Changeset with the original PR?

Nope. Not one that I could find. Unless it the original fix was already released in which case the changeset would have been automatically deleted.

We will need to stub out the changeset in this PR and then manually change the commit SHA in the release PR later so it's tied to the right commit. See this discussion: https://pingidentity.slack.com/archives/C0ANZ21HKCH/p1792080788495179

ancheetah · 2026-10-14T23:40:58Z

I think this is from Claude. Can we gitignore this folder?

ancheetah · 2026-10-14T23:41:35Z

This file can also be deleted if the migration completed successfully

ancheetah · 2026-10-14T23:42:34Z

I swear I tried this but tests were still failing randomly for me, ughhh

chore: fix - upgrade nx - fix ci - fix node issues and upgrade to node 24

chore(token-vault): add changeset for SDKS-5448

85e2cc9

github-actions Bot added root CI labels Oct 14, 2026

nx-cloud Bot reviewed Oct 14, 2026

View reviewed changes

SteinGabriel approved these changes Oct 14, 2026

View reviewed changes

github-actions Bot added sdk test labels Oct 14, 2026

github-actions Bot added docs NX labels Oct 14, 2026

cerebrl reviewed Oct 14, 2026

View reviewed changes

ancheetah commented Oct 14, 2026

View reviewed changes

ryanbas21 force-pushed the aj-ci-updates-2 branch 2 times, most recently from 8325dcd to 2fd8352 Compare October 15, 2026 20:38

github-actions Bot removed the docs label Oct 15, 2026

ancheetah mentioned this pull request Oct 16, 2026

Add missing changeset and update Nx/Node versions #596

Closed

chore: update node version for provenance and trusted publishing

f959b98

chore: fix - upgrade nx - fix ci - fix node issues and upgrade to node 24

ancheetah force-pushed the aj-ci-updates-2 branch from 2fd8352 to f959b98 Compare October 20, 2026 20:35

github-actions Bot added the docs label Oct 20, 2026

ancheetah merged commit ab5f42e into develop Oct 20, 2026
7 checks passed

ancheetah deleted the aj-ci-updates-2 branch October 20, 2026 20:41

ryanbas21 mentioned this pull request Oct 20, 2026

Release PR #599

Open

Conversation

ancheetah commented Oct 14, 2026

JIRA Ticket

Description

Uh oh!

changeset-bot Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

nx-cloud Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Nx Cloud is proposing a fix for your failed CI:

Uh oh!

SteinGabriel left a comment

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cerebrl left a comment

Choose a reason for hiding this comment

Uh oh!

cerebrl Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

ancheetah Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

ancheetah Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

ancheetah Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

ancheetah Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

ancheetah Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

changeset-bot Bot commented Oct 14, 2026 •

edited

Loading

nx-cloud Bot commented Oct 14, 2026 •

edited

Loading

nx-cloud Bot left a comment •

edited

Loading

pkg-pr-new Bot commented Oct 14, 2026 •

edited

Loading

codecov-commenter commented Oct 14, 2026 •

edited

Loading