Repository navigation
perf(build): compiled the kernel and each userland library and app in parallel - #346
Merged
Merged
Conversation
… parallel Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-j$(NPROC), and.NOTPARALLELkeeps userland's own steps in order: the SDK, then the libraries, then the apps, then package staging. Only the compiles inside each library and app run in parallel, so the build output and progress lines read as before.Note
Low Risk
Makefile-only build parallelism with ordered userland phases preserved; no runtime or security impact.
Overview
Speeds up clean builds by passing
-j$(NPROC)into the top-levelkernelanduserlandsub-makes so compilation can use all available cores (e.g. CI’s 4-core runners instead of a single-threaded ~200s userland build).In
userland/Makefile,.NOTPARALLELkeeps the existing pipeline order—SDK, then libraries, then apps, then package staging—so progress output stays readable; parallelism is limited to compiles within each library/app (and the kernel tree), not across those phases.Risk: build orchestration only; output is intended to match serial builds aside from vim embedding its build time.
Reviewed by Cursor Bugbot for commit c6716d8. Bugbot is set up for automated code reviews on this repo. Configure here.