Repository navigation
perf(ci): built the unit test image in the debug build jobs instead of the unit-test jobs - #344
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
…f the unit-test jobs Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make test-imageis the build half ofmake test. The debug build jobs, which build inmake test's default mode, run it on top of the userland they just compiled and upload the image, and the unit-test jobs boot that image with only QEMU installed.Note
Low Risk
CI/Makefile orchestration only; local
make testbehavior is preserved via thetest-imagedependency with no kernel or test logic changes.Overview
CI now builds the QEMU unit-test disk image in debug
buildjobs and reuses it inunit-tests, instead of rebuilding userland twice per pipeline run.The Makefile splits
make testintomake test-image(clean + unit-test-enabledimagebuild) andmake test, which still runstest-imagethenscripts/run_tests.sh. Debug matrix entries runmake test-imagewithPACKAGES="none binutils"after kernel/userland and uploadimages/stellux-<arch>.imgas a short-lived artifact.The
unit-testsjob drops toolchain/sysroot caches and Limine/musl/libc++ setup; it only installs QEMU, downloads the prebuilt image, and invokes./scripts/run_tests.shdirectly (same timeout and log upload as before).Reviewed by Cursor Bugbot for commit 274a18c. Bugbot is set up for automated code reviews on this repo. Configure here.