Repository navigation
Replace deprecated Locale constructors in JsonFormatTest - #366
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #365: resolves the
new Locale(...)warnings in tests.new Locale(...)inJsonFormatTestwith Java 8-compatibleLocaleconstants andLocale.Builder./mvnw test -Dtest=JsonFormatTestpasses locally on JDK 8 and 17. The warnings only appear on JDK 19+, so check them on the CI JDK 21/25 builds.Not addressed:
new Locale(...)inJsonFormat:Locale.of()needs Java 19+ and this branch targets Java 8, andLocale.Builderrejects some inputs the constructors accept, so it could change behavior🤖 Generated with Claude Code