fix: correct typos in WebUI error message and XML doc comments - #175
Open
Avicennasis wants to merge 1 commit into
Open
fix: correct typos in WebUI error message and XML doc comments#175Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement
Summary
Fix 3 typos across 3 files. Each was verified against the current contents of
masterbefore changing."Date begin cannot be greater than after"->"Date begin cannot be greater than date end"a in-memory database->an in-memory database<param name="conditionType">The content type.</param>-><param name="conditionType">The condition type.</param>Notes for reviewers
One change is to a user-facing string, not a comment - please review it deliberately. The
GetRulesHandlermessage is returned in the HTTP 400 body whenIsValidFilterDatesfails. That guard (lines 71-76) returns false only whenDateBegin > DateEnd, so "greater than after" appears to be an unfinished sentence; "date end" matches the naming used for the parameter elsewhere in the codebase (<param name="dateEnd">The date end.</param>). I grepped the whole repository, includingtests/, forDate begin cannot be- this string occurs exactly once, so no test assertions needed updating. If you would rather word it differently, say so and I will amend.The
IRuleBuilderchange corrects a copy-paste in the XML doc only. The documented parameter really isconditionType(see theWithCondition<TDataType>signature on line 52), and the neighbouring<param name="contentType">The content type.</param>on line 65 is correct as-is and untouched. No identifier was renamed.Not included, in case you want it as a follow-up: the same
a in-memory->an in-memoryslip also appears twice insrc/Rules.Framework/Providers/InMemory/InMemoryProviderRulesDataSourceSelectorExtensions.cs(lines 13 and 25). I left those alone to keep this diff to the files listed above - happy to add them here if you would prefer a single sweep.Commit message follows the conventional commits specification per CONTRIBUTING.md, and the branch targets
master.