Repository navigation
Add ImportSecretsAs to import GitHub Actions secrets under an explicit env name - #698
Draft
ChrisonSimtian wants to merge 3 commits into
Draft
ChrisonSimtian wants to merge 3 commits into
ChrisonSimtian wants to merge 3 commits into
Conversation
…t env name ImportSecrets derives the secret name from the parameter name, so it cannot reach secrets such as OPS_API_TESTS_NZPOST_KEY or env names such as Apis__NzPost__FunctionKey. ImportSecretsAs takes "ENV_NAME: SECRET_NAME" entries and emits them on the run step's env block after ImportSecrets. Entries are validated like Env: non-empty env name and secret, no whitespace, and no duplicate env names across both properties. Output is unchanged when the property is empty. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… token is enabled Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ChrisonSimtian
force-pushed
the
hotfix/v10.4.1-import-secrets-as
branch
from
October 5, 2026 00:59
0910b02 to
336cb69
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ImportSecretsderives the secret name from the parameter name. It cannot import a secret likeOPS_API_TESTS_NZPOST_KEY(derivation givesNZ_POST). It also cannot set env names such asApis__NzPost__FunctionKey. Consumers work around this by overriding the protectedGetImports()in a subclass.Outcome
GitHubActionsAttribute.ImportSecretsAsproperty. Entries areENV_NAME: SECRET_NAME.env:asENV_NAME: ${{ secrets.SECRET_NAME }}, afterImportSecrets.Env:ImportSecretsandImportSecretsAsNotes
develop.docs/website/05-cicd/github-actions.md.Tests
ImportSecretsalone, and both properties together.GitHubActionsImportSecretsAsSpecs: malformed entries, duplicates, same secret under two env names.