Skip to content

Add workflow_run trigger to GitHubActionsAttribute - #695

Draft
ChrisonSimtian wants to merge 2 commits into
Fallout-build:developfrom
ChrisonSimtian:hotfix/v10.4.1-github-actions-workflow-run
Draft

ChrisonSimtian wants to merge 2 commits into
Fallout-build:developfrom
ChrisonSimtian:hotfix/v10.4.1-github-actions-workflow-run

Conversation

@ChrisonSimtian

@ChrisonSimtian ChrisonSimtian commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Adds a workflow_run trigger so a generated workflow can start after another workflow finishes (for example, test a deployed environment after the deploy workflow completes).

New GitHubActionsAttribute properties:

  • OnWorkflowRunWorkflows (string[]): upstream workflow names. Setting it enables the trigger.
  • OnWorkflowRunTypes (string[], default completed)
  • OnWorkflowRunBranches (string[])
  • OnWorkflowRunRequireSuccess (bool, opt-in): adds a job-level if: github.event_name != 'workflow_run' || github.event.workflow_run.conclusion == 'success' (so cron or dispatch runs of the same workflow are not skipped), since workflow_run also fires for failed or cancelled upstream runs. This needed a new Condition property on GitHubActionsJob, written as if: only when set.

Behaviour:

  • New GitHubActionsWorkflowRunTrigger is a detailed trigger, so it combines with the other On* triggers and conflicts with shorthand On, via the existing assertion in GetConfiguration.
  • OnWorkflowRunBranches or OnWorkflowRunRequireSuccess without OnWorkflowRunWorkflows throws, as do blank workflow names.
  • Null OnWorkflowRunTypes or OnWorkflowRunBranches throws a clear error.
  • With nothing set, output is unchanged (existing snapshots untouched).

Specs: a workflow-run snapshot in ConfigurationGenerationSpecs plus GitHubActionsWorkflowRunSpecs.

Base: develop, the default PR target. The change is non-breaking and the branch is a plain two-commit addition, so it can be cherry-picked onto the 10.4.x line for a patch release.

ChrisonSimtian and others added 2 commits October 5, 2026 13:38
@ChrisonSimtian ChrisonSimtian added the target/vCurrent Targets the current version label Oct 5, 2026
@ChrisonSimtian
ChrisonSimtian changed the base branch from main to develop October 5, 2026 00:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

target/vCurrent Targets the current version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant