Repository navigation
Add workflow_run trigger to GitHubActionsAttribute - #695
Draft
ChrisonSimtian wants to merge 2 commits into
Draft
ChrisonSimtian wants to merge 2 commits into
ChrisonSimtian wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Moc287uLpiAvVnTmfGuaCE
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Moc287uLpiAvVnTmfGuaCE
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
workflow_runtrigger so a generated workflow can start after another workflow finishes (for example, test a deployed environment after the deploy workflow completes).New
GitHubActionsAttributeproperties:OnWorkflowRunWorkflows(string[]): upstream workflow names. Setting it enables the trigger.OnWorkflowRunTypes(string[], defaultcompleted)OnWorkflowRunBranches(string[])OnWorkflowRunRequireSuccess(bool, opt-in): adds a job-levelif: github.event_name != 'workflow_run' || github.event.workflow_run.conclusion == 'success'(so cron or dispatch runs of the same workflow are not skipped), sinceworkflow_runalso fires for failed or cancelled upstream runs. This needed a newConditionproperty onGitHubActionsJob, written asif:only when set.Behaviour:
GitHubActionsWorkflowRunTriggeris a detailed trigger, so it combines with the otherOn*triggers and conflicts with shorthandOn, via the existing assertion inGetConfiguration.OnWorkflowRunBranchesorOnWorkflowRunRequireSuccesswithoutOnWorkflowRunWorkflowsthrows, as do blank workflow names.OnWorkflowRunTypesorOnWorkflowRunBranchesthrows a clear error.Specs: a
workflow-runsnapshot inConfigurationGenerationSpecsplusGitHubActionsWorkflowRunSpecs.Base:
develop, the default PR target. The change is non-breaking and the branch is a plain two-commit addition, so it can be cherry-picked onto the 10.4.x line for a patch release.