Repository navigation
fix: skip the README request when the asset has no README.md - #9
Merged
Merged
Conversation
The asset detail page asked GET .../readme for every asset and treated the 404 as "no README". The Functions host records those 404s as failed requests, and six of them tripped the prod failed-requests alert on 2026-09-28. The page already loads the file listing, so request the README only when README.md is listed, and fall back to asking if the listing fails. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On 2026-09-28 the prod alert
alert-atk-prod-failed-requestsfired with no server errors. The cause was sixGET /assets/skill/*/readme404s from one session browsing assets that have no README.md. The API is fine; the Functions host counts 4xx as failed requests. (The alert itself is being moved to 5xx only in ADO PR 1577.)Change
useAssetReadme(ref, { enabled }): new optionalenabledflag (defaults to true).AssetDetail: the page already loads/files, so it requests/readmeonly whenREADME.mdis listed. It waits for the listing, still asks if the listing fails, and shows the README skeleton while the listing loads.Not covered: the bundle page (
useBundleReadme) and CLIatk infostill get a 404 when there's no README. Bundles have no file listing to check first.typecheck, lint and
vitest run(349 tests) pass.🤖 Generated with Claude Code