[nemeregiftbrown-byte]

Description

Adds comprehensive test coverage for mobile/src/screens/HomeScreen.tsx and mobile/src/screens/EvidenceCaptureScreen.tsx (fulfilling issues #280 and #279), stabilizes mobile test assertions under concurrent runs, fixes root determinism error handling in test scripts, resolves merge conflicts with upstream/main, and repairs CI runner setup for mobile E2E smoke jobs.

Rebased cleanly onto latest upstream/main.

---

Summary of Changes

1. Case #280 — mobile/src/screens/HomeScreen.test.tsx (6 tests)

• Notification handler configuration: Verifies Notifications.setNotificationHandler is initialized with alert, sound, and badge options set to true.
• Primary render states:
  • Verifies application title (Amana Mobile) and subtitle (Trust as a Service for Agricultural Products).
  • Verifies the Getting Started section header and onboarding description text.
• Key interactions and subscription lifecycle:
  • Verifies Notifications.addNotificationResponseReceivedListener is registered on mount.
  • Verifies the response received callback logs incoming notifications.
  • Verifies the subscription is properly cleaned up on component unmount (subscription.remove()).

2. Case #279 — mobile/src/screens/EvidenceCaptureScreen.test.tsx (17 tests)

• Primary render states: Verifies header title, accessibility roles, formatted trade reference (Trade: #${tradeId.slice(0, 12)}…), evidence type selection tabs (Video/Photo), and initial capture placeholder.
• Navigation: Verifies pressing the header back button calls navigation.goBack().
• Media type switching: Verifies toggling between Video and Photo updates accessibility state, section titles, guidance hint texts, placeholder labels, and resets any in-progress capture state.
• Capture simulation & Retake:
  • Verifies pressing capture triggers the appropriate device simulation Alert (Record Video / Take Photo).
  • Verifies dismissing the alert retains idle state.
  • Verifies selecting Simulate Capture captures media with proper file extensions (.mp4 / .jpg), updates state to captured, displays preview cards, and presents the retake button.
  • Verifies pressing Retake clears captured media and returns the UI to idle capture mode.
• Multipart Upload & Loading States:
  • Verifies that uploading displays an in-flight loading spinner with disabled/busy button states.
  • Verifies POST /trades/:tradeId/evidence is called with multipart FormData including file, tradeId, and mediaType payload fields.
  • Verifies Authorization: Bearer <token> header is included when authenticated, and omitted when no token is present in authStore.
• Error Handling & Retry:
  • Verifies upload errors display an alert-role banner with assertive live region containing the error message (or fallback for non-Error exceptions).
  • Verifies the upload button is re-enabled to allow retry upon failure.
• Success State:
  • Verifies successful upload displays the confirmation card and provides a Back to Trade navigation button triggering navigation.navigate('TradeDetail', { tradeId }).

3. Mobile Test Suite Execution

• Updated mobile/package.json test script to jest --runInBand. Running 32 React Native test suites in band stabilizes execution, completing in ~16s deterministically without resource exhaustion.
• Stabilized mobile/src/screens/AdminStreamsOverviewScreen.test.tsx by awaiting replacement of placeholder stream-001 seed before asserting rendered action button counts (waitFor).

4. CI Fixes & Gate Reliability

• scripts/verify-test-determinism.sh: Added || true to the error extraction grep pipeline so set -eo pipefail does not abort early when cargo fails before generating matching test error strings, allowing the test determinism suite to pass all 11 assertions.
• .github/workflows/ci.yml:
  • Backend Required Gate: Scoped Install deps and Apply database migrations with if: needs.changes.outputs.backend == 'true', preventing migration crashes on non-backend PRs.
  • Contracts Required Gate: Guarded Rust setup and cargo-audit behind if: needs.changes.outputs.contracts == 'true'.
  • Mobile E2E Smoke (iOS):
    • Inline dynamic ExpoConfig in mobile/app.config.ts replacing unexported getDefaultConfig.
    • Added placeholder mobile assets (mobile/assets/README.md) unblocking Expo prebuild.
    • Added simulator resolution at runtime (IOS_SIM_NAME/OS/UDID).
    • Added brew trust --formula wix/brew/applesimutils to satisfy Homebrew tap trust requirements when installing applesimutils.
  • Mobile E2E Smoke (Android):
    • Updated to setup-android@v4 (resolving issue android-actions#537).
    • Added KVM group permissions on Linux runners for hardware-accelerated emulation.
    • Removed broken manual avdmanager create avd call that exited with code 1 due to uninstalled system-images; delegated AVD creation and system-image downloading to reactivecircus/android-emulator-runner@v2 with force-avd-creation: false and -no-snapshot-save.
    • Included mobile/app.config.ts in Android prebuild cache key.

---

Related Issues

• Closes mobile: add test coverage for src/screens/HomeScreen.tsx #280
• Closes mobile: add test coverage for src/screens/EvidenceCaptureScreen.tsx #279

Type of Change

• Test coverage additions (mobile/src/screens/HomeScreen.test.tsx, mobile/src/screens/EvidenceCaptureScreen.test.tsx)
• Infrastructure / CI / Policy update (.github/workflows/ci.yml, scripts/verify-test-determinism.sh, test stabilization)

🔒 Required CI Gates

• Scripts Unit Tests Gate: pnpm test:scripts passes (14/14 suites, 191/191 tests pass)
• Flaky Quarantine Registry: node scripts/validate-flaky-quarantine.mjs passes
• Feature Flag Catalog Drift: npx --yes tsx scripts/check-flag-catalog-drift.ts passes
• Event Schema Drift Gate: node scripts/codegen-events.mjs --check passes
• Mobile Required Gate: pnpm type-check (0 errors), pnpm lint (0 errors), pnpm test (32/32 suites, 317/317 tests pass)
• Frontend Required Gate: skipped (no frontend/ changes)
• Backend Required Gate: skipped (no backend/ changes)
• Contracts Required Gate: skipped (no contracts/ changes)

PR Checklist

• Code builds and passes all unit & integration tests locally (pnpm test in mobile/ passes 32/32 suites, 317/317 tests)
• pnpm type-check in mobile/ passes with 0 errors (tsc --noEmit)
• pnpm lint in mobile/ passes with 0 errors
• Documentation integrity maintained; test fixtures use mock parameters
• Admin Regression Tests: Preserved
• Secret Management: No secrets, private keys, or credentials added
• Network Isolation & Security: Preserved

[drips-wave]

@nemeregiftbrown-byte Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[EmeditWeb]

@nemeregiftbrown-byte fix CI issues

[nemeregiftbrown-byte]

PR #378 Summary — test(mobile): HomeScreen & EvidenceCaptureScreen coverage + CI gate repairs

References: #280 (HomeScreen tests), #279 (EvidenceCaptureScreen tests).

What this PR delivers

1. New mobile screen coverage
   • mobile/src/screens/EvidenceCaptureScreen.test.tsx — comprehensive coverage for capture stages, media-source selection, validation errors, upload states, retry flows, and accessibility labels.
   • mobile/src/screens/HomeScreen.test.tsx — coverage for notification handler setup, primary render states, and notification response subscription lifecycle.
2. Deterministic mobile test suite execution
   • Updated mobile/package.json test script to jest --runInBand. Running 32 React Native test suites concurrently previously overloaded runner resources, causing Pact mock HTTP server dropped requests in tests/pact/trades.pact.test.ts and test timeouts in AdminStreamsOverviewScreen.test.tsx. Running in band stabilizes all tests and completes in ~16s (down from 58s with failures).
   • Stabilized AdminStreamsOverviewScreen stream-list assertion to explicitly wait for stream-001 placeholder removal and stream-100 presence.
3. CI gate repairs:
   • Contracts Required Gate: Guarded Setup Rust, Install cargo-audit, and Security audit (cargo) behind if: needs.changes.outputs.contracts == 'true'. Previously these steps ran unconditionally even when no contract files changed, triggering spurious failures.
   • Dependency Isolation: Reverted unnecessary modification to contracts/Cargo.lock, ensuring contracts is not flagged as changed and preventing the PR from triggering the standalone Security Audit workflow (.github/workflows/security-audit.yml).
   • Frontend Gate: Increased timeout from 8 → 15 minutes.
   • Backend Gate: Skips pnpm install / prisma migrate deploy when no backend files changed.
   • Scripts Tests & Determinism: Fixed verify-test-determinism.sh to safely handle empty grep matches without aborting pipeline.
4. Setup-level Mobile E2E repairs:
   • Android E2E Smoke: Updated to setup-android@v4 (resolving issue android-actions#537 where @v3 attempted to install obsolete tools package).
   • iOS E2E Smoke:
     • Corrected mobile/app.config.ts to export inline ExpoConfig without unexported getDefaultConfig.
     • Committed placeholder mobile assets referenced in configuration (mobile/assets/README.md).
     • Dynamically resolved available iOS simulator runtime and UDID at runtime.
     • Installed required iOS test tooling (xcpretty and applesimutils) on macOS runners.

Verification

• mobile:
  • pnpm type-check → clean (0 errors)
  • pnpm lint → 0 errors
  • pnpm test → 32/32 test suites passed, 317/317 tests passed cleanly in 16.2s
• scripts:
  • pnpm test:scripts → 14/14 test suites passed, 191/191 tests passed
  • node scripts/validate-flaky-quarantine.mjs → OK (0 expired entries)
• .github/workflows/ci.yml:
  • Verified valid YAML syntax and proper path-filter conditionals across all gates.

Follow-ups for reviewers

• Replace placeholder mobile/assets/ with final artwork when design ships it.
• Keep the E2E smoke jobs continue-on-error only until one full green Detox run; then re-enable hard gating.

[nemeregiftbrown-byte]

CI Repair Update: Mobile E2E Smoke (iOS & Android)

Pushed commit 2ba024b9 fixing the setup-level failures in the Mobile E2E Smoke jobs:

1. iOS Smoke Job (mobile-e2e-ios):

   • Modern Homebrew rejects installing formulae from third-party taps by default. Added brew trust --formula wix/brew/applesimutils following brew tap wix/brew, allowing applesimutils to install without rejection.

2. Android Smoke Job (mobile-e2e-android):

   • Added KVM permission configuration (/etc/udev/rules.d/99-kvm4all.rules) for hardware-accelerated emulation on Ubuntu runners.
   • Removed the broken manual avdmanager create avd step which was failing with Valid system image paths are: null (as system images were not yet installed via sdkmanager).
   • Delegated full AVD provisioning and system-image downloading to reactivecircus/android-emulator-runner@v2 with force-avd-creation: false and -no-snapshot-save.
   • Added mobile/app.config.ts to the Android prebuild cache key to align with iOS and prevent stale prebuild cache corruption.

3. Local Verification:

   • mobile: pnpm type-check (0 errors), pnpm lint (0 errors), pnpm test (32/32 suites passed, 317/317 tests passed).
   • scripts: pnpm test:scripts (14/14 suites passed, 191/191 tests passed).
   • quarantine: node scripts/validate-flaky-quarantine.mjs (0 expired entries).
   • .github/workflows/ci.yml: valid YAML syntax.