Remove types dir - #578
Open
Justin Hammond (Justintime50) wants to merge 2 commits into
Open
Conversation
Justin Hammond (Justintime50)
changed the base branch from
master
to
node18_deps
September 2, 2026 17:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the great TS migration, the
typesdir removal got rolled back which was intended to no longer exist. Some references to it remained. This cleans up the types dir and references to align with the desired end-state of the types dir being a build artifact only and not checked into the repo.Oddly enough, after putting this up for review, I realized that the
errorsdir had not been migrated to TS either - some revert blew up badly during the migration and I hadn't noticed it. Including those here because otherwise CI won't pass Typescript checks.Testing
All previous tests and TS checking passes.
Pull Request Type
Please select the option(s) that are relevant to this PR.