Repository navigation
Separate IRM default and return-type tests - #406
Open
leninworld wants to merge 1 commit into
Open
leninworld wants to merge 1 commit into
leninworld wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses part of issue #298.
Description
Move the legacy DoubleMLIRM default and return-type tests into
doubleml/irm/tests/, using the existing shared assertion helpers. Preserve the explicit IRM defaults, learner-parameter check, fitted property and nuisance-output shapes, sensitivity checks, and both policy-tree contracts. Remove the corresponding IRM coverage from the two root test modules.The fitted IRM fixture uses the supported
PSProcessorConfig(clipping_threshold=0.1)configuration. Production code and public APIs are unchanged. Other model families and the external testing guide remain outside this partial migration.Reference to Issues or PRs
Related to #298. This PR does not complete or close the broader issue.
Validation
rdrobust==2.0.0, dependencies frozen from the repository lockfile.python -m pytest . -p no:cacheprovider --tb=short --junitxml=/results/full-suite-a2.xml.d8248099c0fefd76eb5f34daf085701eab6314ca: 6 passed in 2.53 seconds; Ruff passed for all four changed files with--no-cache.PR Checklist
Local validation evidence