Repository navigation
fix: raise generated dependency floors to PHP 8.5 deprecation-free releases - #161
Merged
Merged
Conversation
…leases Generated composer.json now requires docler-labs/api-client-exception ^1.0 || ^2.3.1 and guzzlehttp/psr7 ^1.6 || ^2.7, so on PHP 7.4+ Composer can only resolve releases that run without PHP 8.4+ deprecations. The 1.x lines stay allowed for the older CLIENT_PHP_VERSION targets. The example and example3_1 lockfiles move to api-client-exception 2.3.1, so the acceptance tests pass on PHP 8.5 with deprecations as errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The acceptance tests regenerate example/ and example3_1/ PetStoreClient. The committed copies predated 11.2.0, so BodySerializer lacked the RFC 6839 +json content type handling the generator already emits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated clients target
CLIENT_PHP_VERSION8.3 ("php": "^8.3") and run unchanged on PHP 8.5, but theircomposer.jsonstill let Composer resolve dependency releases that raise PHP 8.4+ deprecations inside the client. This PR raises only those floors.CLIENT_PHP_VERSION, the templates and the generated code are all unchanged.Generated
composer.jsondocler-labs/api-client-exception^1.0 || ^2.0^1.0 || ^2.3.1UnexpectedResponseException(fixed in 2.3.1)guzzlehttp/psr7(Guzzle HTTP message)^1.6 || ^2.6^1.6 || ^2.7Uri.phpthat the generatedGuzzleRequestMapperhitsThe 1.x lines stay, so the older targets still resolve: api-client-exception 1.x needs
^7.0, psr7 1.x needs>=5.4. On PHP 7.4 and later, Composer can now only pick releases that run deprecation-free on PHP 8.5.Examples
exampleandexample3_1lockfiles move to api-client-exception 2.3.1 (from 2.0.0) and psr7 2.13.1. The acceptance tests exercise these, and on PHP 8.5 they used to fail with deprecations as errors.BodySerializerwith the current generator output. The acceptance run regenerates it, and the committed copy was older than the RFC 6839+jsonsupport released in 11.2.0.Verification
make test(PHP 8.2 + wiremock, as CI runs it): OK, 449 tests, 1038 assertions.error_reporting=-1: OK, 2 tests, and the generated example clients raise no deprecations. (The generator's own dev dependencycomposer/composer2.2.30 LTS still prints deprecations on 8.5. That affects only the test harness, not generated code; CI runs on 8.2.)phpVersion: 80500) and exercised at runtime on PHP 8.5. After api-client-exception 2.3.1, their only remaining deprecation source is gone.CHANGELOG entry: 11.2.3. It also covers the composer/composer 2.2.30 bump from #160.
🤖 Generated with Claude Code