Skip to content

#Closes 211 - #519

Open
actvabdulrahman wants to merge 4 commits into
Divinity-Labs:mainfrom
actvabdulrahman:main
Open

actvabdulrahman wants to merge 4 commits into
Divinity-Labs:mainfrom
actvabdulrahman:main

Conversation

@actvabdulrahman

Copy link
Copy Markdown

Summary

Includes Phoenix pools in the /pools endpoint alongside existing pools,
tags every pool in the response with its venue, updates the OpenAPI schema
to reflect the new venue field, and adds a mixed-venue test asserting
pools from multiple venues appear correctly in the response.

Related issue

Closes #211

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Docs
  • Tests
  • CI / tooling

Checklist

  • I have read CONTRIBUTING.md

  • npx tsc --noEmit passes

  • npm run build passes

  • I added / updated tests where relevant

  • I updated docs where relevant

  • Phoenix pools now listed in /pools alongside existing pools

  • Every pool in the response carries a venue field identifying its source

  • openapi.yaml updated to include venue as a required field on pool objects

  • tests/openapi.test.ts passes against the updated schema

  • Mixed-venue test added asserting pools from Phoenix and existing venues appear correctly

  • Phoenix adapter follows aquarius.ts reference structure including _resetLastPrice() for test isolation

  • All price_points rows written by the Phoenix adapter carry the correct network value from ENABLED_NETWORKS

@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@actvabdulrahman Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Miracle656 Miracle656 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screened against current main: this has 6 type errors on its own branch, so it needs work beyond a rebase.

Run npx tsc --noEmit after rebasing and you will see them. A fair number of PRs here today failed the same way, and in most cases it was a helper that gained a parameter, or a symbol that lives on another branch and never arrived with this one.

Two guards worth knowing about before you re-request, because both caught PRs today:

  • console.* is forbidden in non-test source — use createLogger
  • tests/openapi.test.ts fails if a route is documented but not registered in src/app.ts, or registered but not documented

Get tsc and vitest both clean locally and I will review it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phoenix pools are not in /pools, so nobody can see what is watched

2 participants