Repository navigation
#Closes 211 - #519
#Closes 211#519actvabdulrahman wants to merge 4 commits into
Conversation
|
@actvabdulrahman Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Miracle656
left a comment
There was a problem hiding this comment.
Screened against current main: this has 6 type errors on its own branch, so it needs work beyond a rebase.
Run npx tsc --noEmit after rebasing and you will see them. A fair number of PRs here today failed the same way, and in most cases it was a helper that gained a parameter, or a symbol that lives on another branch and never arrived with this one.
Two guards worth knowing about before you re-request, because both caught PRs today:
console.*is forbidden in non-test source — usecreateLoggertests/openapi.test.tsfails if a route is documented but not registered insrc/app.ts, or registered but not documented
Get tsc and vitest both clean locally and I will review it properly.
Summary
Includes Phoenix pools in the
/poolsendpoint alongside existing pools,tags every pool in the response with its venue, updates the OpenAPI schema
to reflect the new
venuefield, and adds a mixed-venue test assertingpools from multiple venues appear correctly in the response.
Related issue
Closes #211
Type of change
Checklist
I have read CONTRIBUTING.md
npx tsc --noEmitpassesnpm run buildpassesI added / updated tests where relevant
I updated docs where relevant
Phoenix pools now listed in
/poolsalongside existing poolsEvery pool in the response carries a
venuefield identifying its sourceopenapi.yamlupdated to includevenueas a required field on pool objectstests/openapi.test.tspasses against the updated schemaMixed-venue test added asserting pools from Phoenix and existing venues appear correctly
Phoenix adapter follows
aquarius.tsreference structure including_resetLastPrice()for test isolationAll
price_pointsrows written by the Phoenix adapter carry the correctnetworkvalue fromENABLED_NETWORKS