Repository navigation
Conversation
|
@flare-999 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
f15d4c7 to
02184f9
Compare
Strips the payload this branch picked up (deleted api.js, unhooked package.json). No functional change to the branch's own work.
|
Closing this unreviewed. This branch carries the PolinRider credential stealer.
Simply opening this branch in an editor to review it executes the payload. It targets npm, package registry and GitHub tokens, and propagates by opening further pull requests from the accounts it compromises. Nothing from this PR reached The stated change may well be real work. Eight branches across this repository carry the same payload from seven different accounts, several of which have legitimate contribution histories, which is consistent with compromised developer machines rather than accounts created to attack us. If that is what happened to you, the practical steps are:
Once your machine is clean, re-open the change from a fresh branch and I will review it properly. I am not holding the contribution against you. I have reported the account to GitHub, which is standard for this and not an accusation. |
Overview
This PR adds
volumesandspreadsGraphQL queries that mirror the existing REST routes/volumes/:assetand/spreads/:asset. Per-venue results are exposed as a typedVenueQuotelist so clients can select exactly the fields they need per venue, and both queries are network-aware. The underlying data-fetching logic is shared between REST and GraphQL so the two surfaces cannot drift.Related Issue
Changes
📊 GraphQL queries for volumes and spreads
[MODIFY]
src/api/graphql.tsvolumes(asset: String!, network: String)andspreads(asset: String!, network: String)queries.VenueQuoteGraphQL type exposing per-venue fields as a typed list (not a map or string).[MODIFY]
src/api/rest.ts/volumes/:assetand/spreads/:assethandlers to the shared implementations so both surfaces return the same data for the same input.[MODIFY]
src/routes/volumes.tsnetworkparameter through so the shared path is network-aware.[MODIFY]
src/routes/spreads.ts[VenueQuote!]!.networkparameter through so the shared path is network-aware.🧪 Tests
src/__tests__/spreads.test.ts/spreads/:assetroute and thespreadsGraphQL query for the same asset and network input.Verification Results
volumesandspreadsqueries added, backed by the same shared functions as the REST routesVenueQuotetype exposed as a list in the GraphQL schemanetworkargument threaded through the shared implementationssrc/routes/volumes.tsandsrc/routes/spreads.tsexport shared functions consumed by both surfacessrc/__tests__/spreads.test.tscompares REST and GraphQL output for identical inputCloses #368