Ble support for iOS - #5
Draft
Ben1980 wants to merge 68 commits into
Draft
Conversation
…into usb-support
Ben1980
commented
Mar 8, 2024
conkleon
added a commit
to conkleon/flutter_divecomputer
that referenced
this pull request
Aug 27, 2026
…al review - ackOutbound(seq, status): ack the exact sequence written, never the current writeSeq; add a re-entrancy guard so the 4ms mailbox timer cannot start a second concurrent GATT write (DiveNote#1) - notification listener reads the _bridge FIELD and checks isClosed, preventing a push into memory freed by teardown/dispose (DiveNote#2) - download(): group allocate/attach/send in a try that disposes the bridge and rethrows, so an early failure can neither leak the bridge nor hang forever awaiting a _BleBridgeReleased that will never come (DiveNote#3) - guard _bleBridgeReleased.complete() against StateError wedging the ReceivePort listener (DiveNote#5) - enableDebugLogging() now drives Logger('BleBridge') on the background isolate and Logger('BleTransport') on the main isolate, both forwarded to developer.log via a shared helper (DiveNote#6) - scan(): drop results after close, clear the global onScanResult handler and _seen on cancel (DiveNote#7) - connect(): disconnect the GATT link on any post-connect failure before the retry loop opens a new one (#11) - export ble_profile.dart / ble_scan_result.dart from the barrel and drop the example's deep import (#16) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.