Repository navigation
fix(motion-kit): drop the grab-bar span and refuse classes no SCSS module defines - #125
Merged
Merged
Conversation
…dule defines render.tsx read boardStyles.handle after the class left Whiteboard.module.scss, so every card carried an empty span. missingClasses in stateClasses.ts now checks every Styles read against the compiled class maps, and generate refuses a film that fails it. An activity turn line without the step class now throws instead of yielding no hooks. Closes #95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slotinmotion-kit/render.tsxrendered<span className={boardStyles.handle}>after.handleleftWhiteboard.module.scss, so every card in a film carried an empty span. The span is gone.missingClassesinmotion-kit/stateClasses.tswalks the TypeScript AST for everyxStyles.nameread on an SCSS module import and checks it against the compiled class maps thatloadRendereralready returns, andgeneraterefuses a film that fails it. An Activity turn line without the step class now throws instepLines, so a class that moves off the line can no longer yield zero hooks without an error.The Kenya film builds from this branch with the current Activity tab, card source lines, card chips and More Info. Played headless in Chromium, scrubbed from 0 to 24.8 s and then played in real time, all 26 cues in its cue sheet fire with no console error and no
DFO: nothing aterror. The committed Kenya JSON and cue files are unchanged;feat/motion-kitrewrites them. Once that branch is rebased onto dev, the new check fails on itsboardStyles.handleandactivityStyles.toolreads, which is the check working.Closes #95
Testing:
node --test motion-kit/test/*.test.ts(20 pass, including the Kenya film built in Chrome),pnpm typecheck,pnpm lint. With the span restored, both the class test and the Kenya film test fail onmotion-kit/render.tsx: boardStyles.handle.