Repository navigation
fix(share): drop the share_card_result table and the dead live_unavailable refusal - #123
Merged
Merged
Conversation
…lable refusal Shares are served by dfo-apis, so nothing reads or writes share_card_result. Migration 0024 drops it. shareDialog.ts loses the live_unavailable refusal and the unavailable withdrawal, whose only emitter was the deleted liveShare.ts. Closes #78
jm-rivera
changed the title
jm-rivera
marked this pull request as ready for review
November 5, 2026 11:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shares are served by dfo-apis, so nothing in the website reads or writes
share_card_result. Migration0024_drop_share_card_resultdrops the table, anddb/schema.tsno longer defines it.shareDialog.tsloses thelive_unavailablerefusal and theunavailablewithdrawal, whose only emitter wasliveShare.ts, deleted in #119. The rest of #78's list (liveShare.ts,liveShareResults.ts,LIVE_SHARE_WINDOW_S,DOWNLOAD_PENDING,liveRefusaland the refresh parts ofliveBackend.ts) went in #119.Production still runs code from before #119, but nothing on it reads the table since #77, so the drop is safe in the release that carries #119.
This is the bottom of a stack. Above it: the snapshot poll check (#79), the motion-kit class check (#95) and the footer and caption contrast fix (#35).
Closes #78
Testing:
pnpm lint,pnpm lint:css,pnpm typecheck,pnpm test(2282 pass),pnpm build, and the migrate and migrate-shares bundle smoke steps.db/migrate-local.tsapplies all 25 migrations and leaves noshare_card_result.scripts/share-migration-round-trip.tspassed twice (33 checks each) against a website built from this branch with 0024 applied and the dfo-apis local stack at f8d35d9 seeded. The run neededAccept-Encoding: identityon its fetches, because the/api/v1proxy sends gzip bodies withoutContent-Encoding, which is a separate bug.