Skip to content

Clarify Comic Manifest approval expiry boundaries - #15

Merged
andrewperis merged 5 commits into
mainfrom
codex/issue-95-approval-expiry-boundaries
Oct 6, 2026
Merged

andrewperis merged 5 commits into
mainfrom
codex/issue-95-approval-expiry-boundaries

Conversation

@andrewperis

@andrewperis andrewperis commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Make the existing approval time check explicit in RFC 0007 and the Comic Manifest candidate specification: decided_at <= action_time < expires_at, with the scoped publication_time < expires_at check preserved.
  • Validate the trusted action time and compared approval/publication timestamps for real calendar dates and supported clock fields before comparison; reject malformed values without using Date.parse.
  • Support clock seconds 00–59 for temporal authority. Fail closed on every second=60 timestamp, including shapes that JSON Schema date-time format accepts; no leap-second dates are inferred.
  • Preserve fractional-second precision through the schema's maximum length and its accepted T, t, and single-whitespace separators; add boundary, calendar, clock, precision, and leap-second fixtures.
  • Keep the change within the unreleased Comic Manifest candidate and its test documentation.

Validation on exact head ebbff35e46fe2bb21e32f0284a481b42e58f4d50

  • npm run test:comic — 133 passed.
  • npm test — 244 passed, including release-bundle reproducibility checks.
  • git diff --check — passed.
  • GitHub Actions Contract conformance run Define Context Builder v1 producer contracts (Studio #76) #11 — success on both Node 22 and Node 24 jobs; each ran npm ci --ignore-scripts and npm test for this head.

Draft for independent review. Human approval is still required; this PR does not merge or release a contract.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T20:05:58.876958Z ebbff35 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@andrewperis
andrewperis marked this pull request as draft October 6, 2026 18:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59c287ad24

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/support/comic-manifest-oracle.cjs Outdated
@andrewperis
andrewperis marked this pull request as ready for review October 6, 2026 19:01

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb4065c8e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/support/comic-manifest-oracle.cjs Outdated
@andrewperis
andrewperis marked this pull request as draft October 6, 2026 19:44
@andrewperis
andrewperis marked this pull request as ready for review October 6, 2026 20:03
@andrewperis
andrewperis merged commit 8044643 into main Oct 6, 2026
2 checks passed
@andrewperis
andrewperis deleted the codex/issue-95-approval-expiry-boundaries branch October 6, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant